Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(India): Tax calculation for overseas suppliers #29499

Merged
merged 2 commits into from
Jan 30, 2022

Conversation

deepeshgarg007
Copy link
Member

@deepeshgarg007 deepeshgarg007 commented Jan 29, 2022

GST was getting applied applied even for Overseas suppliers with no gst state or GSTIN

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Jan 29, 2022
@deepeshgarg007 deepeshgarg007 added Skip Manual Testing The changes in this PR does not require manual testing and removed needs-tests This PR needs automated unit-tests. labels Jan 29, 2022
@deepeshgarg007 deepeshgarg007 changed the title fix(India) Tax calculation for overseas suppliers fix(India): Tax calculation for overseas suppliers Jan 29, 2022
@codecov
Copy link

codecov bot commented Jan 29, 2022

Codecov Report

Merging #29499 (92416d8) into develop (eba0621) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop   #29499      +/-   ##
===========================================
+ Coverage    58.51%   58.55%   +0.03%     
===========================================
  Files         1091     1091              
  Lines        67999    68000       +1     
===========================================
+ Hits         39793    39814      +21     
+ Misses       28206    28186      -20     
Impacted Files Coverage Δ
erpnext/regional/india/utils.py 62.26% <100.00%> (-2.20%) ⬇️
.../report/delayed_item_report/delayed_item_report.py 60.78% <0.00%> (-35.30%) ⬇️
...saction/incorrect_balance_qty_after_transaction.py 90.69% <0.00%> (-9.31%) ⬇️
...work_order_stock_report/work_order_stock_report.py 94.11% <0.00%> (-5.89%) ⬇️
erpnext/stock/report/stock_ledger/stock_ledger.py 82.11% <0.00%> (-2.44%) ⬇️
.../report/bom_operations_time/bom_operations_time.py 89.13% <0.00%> (-2.18%) ⬇️
erpnext/stock/report/stock_ageing/stock_ageing.py 91.32% <0.00%> (-1.74%) ⬇️
erpnext/stock/reorder_item.py 76.92% <0.00%> (-0.86%) ⬇️
erpnext/assets/doctype/asset/asset.py 78.88% <0.00%> (-0.82%) ⬇️
... and 25 more

@deepeshgarg007 deepeshgarg007 merged commit d41f71a into frappe:develop Jan 30, 2022
@deepeshgarg007
Copy link
Member Author

@Mergifyio backport version-13-hotfix

@mergify
Copy link
Contributor

mergify bot commented Jan 30, 2022

backport version-13-hotfix

✅ Backports have been created

deepeshgarg007 added a commit that referenced this pull request Jan 31, 2022
…-29499

fix(India): Tax calculation for overseas suppliers (backport #29499)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Skip Manual Testing The changes in this PR does not require manual testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant