-
Notifications
You must be signed in to change notification settings - Fork 7.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Provisional accounting for expenses #29451
feat: Provisional accounting for expenses #29451
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #29451 +/- ##
===========================================
- Coverage 58.57% 58.35% -0.22%
===========================================
Files 1091 1097 +6
Lines 67886 68841 +955
===========================================
+ Hits 39765 40174 +409
- Misses 28121 28667 +546
|
@deepeshgarg007 I think we should add a field for "Provisional Account" in the Purchase Receipt so that the user can change it in the transaction. It can be set by default using the default provisional account defined in the company. |
@Mergifyio backport version-13-hotfix |
🟠 Waiting for conditions to match
|
"fieldname": "provisional_expense_account", | ||
"fieldtype": "Link", | ||
"hidden": 1, | ||
"label": "Provisional Expense Account", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fetch from company if blank
* feat: Provisonal accounting for expenses * fix: Method for provisional accounting entry * chore: Add test case * fix: Remove test case * fix: Use company doctype * fix: Add provisional expense account field in Purchase Receipt Item * fix: Test case * fix: Move provisional expense account to parent * fix: Patch (cherry picked from commit 528c713) # Conflicts: # erpnext/accounts/doctype/purchase_invoice/purchase_invoice.py # erpnext/patches.txt # erpnext/setup/doctype/company/company.json # erpnext/stock/doctype/purchase_receipt/purchase_receipt.py # erpnext/stock/doctype/purchase_receipt/test_purchase_receipt.py
✅ Backports have been created
|
…-29451 feat: Provisional accounting for expenses (backport #29451)
* feat: Provisonal accounting for expenses * fix: Method for provisional accounting entry * chore: Add test case * fix: Remove test case * fix: Use company doctype * fix: Add provisional expense account field in Purchase Receipt Item * fix: Test case * fix: Move provisional expense account to parent * fix: Patch (cherry picked from commit 528c713) # Conflicts: # erpnext/accounts/doctype/purchase_invoice/purchase_invoice.py # erpnext/patches.txt # erpnext/setup/doctype/company/company.json # erpnext/stock/doctype/purchase_receipt/purchase_receipt.py # erpnext/stock/doctype/purchase_receipt/test_purchase_receipt.py (cherry picked from commit a54c847) # Conflicts: # erpnext/patches.txt
Provisional Accounting Entry for Expenses (Non-Stock Item Purchases)
Step 1: Enable Provisional Accounting in Company Master and set default provision account
Step 2: Make a Purchase Receipt For a non-stock item
Expected GL Entries on posting of Purchase Receipt
Step 3: Make a Purchase Invoice against the Purchase Receipt
Expected GL Entries on posting Purchase Invoice
Against Purchase Invoice:

Aginst Purchase Receipt (GL entries against purchase receipt should be reversed), remember to remove group by filter in General Ledger report to view this:
Now you may be wondering why we are doing all this, lets try and understand this with an example. In many scenarios lets say a services is received and the expense is incurred but the Invoice is done later, so this expense doesn't flow into your month end MIS if the purchase invoice is made in the later month. This feature aims to solve that issue. On posting a purchase receipt for that Non Stock Item provisional accounting entries will be passed and the same will be reversed on posting the actual purchase invoice on the purchase invoice posting date.
docs: https://docs.erpnext.com/docs/v13/user/manual/en/accounts/purchase-invoice/edit?wiki_page_patch=4c596d26e3