fix: barcode is always deleted and inserted each time an item is saved

[britlog]

Hi,

Problem : the barcode is always deleted and inserted each time an item is saved.

Why : the test if item_barcode.barcode != item_barcode.name: is always false because item_barcode.name is a hash.

Origin : it was done for #21661 but it is no more valid because the name for the child table Item Barcode is now a hash and no more based on the fieldname, it is forced in set_new_name() :

elif getattr(doc.meta, "istable", False): doc.name = make_autoname("hash", doc.doctype)

Tests

select * from `tabItem Barcode`
name	creation	modified	modified_by	owner	docstatus	parent	parentfield	parenttype	idx	barcode
20f80379a3	2022-01-21 14:54:15.369	2022-01-22 12:37:09.940	Administrator	Administrator	0	75163	barcodes	Item	1	abc
6957c39bac	2022-01-21 12:33:57.147	2022-01-22 12:36:50.126	Administrator	Administrator	0	TEST ITEM	barcodes	Item	1	123

[ankush]

@Mergifyio backport develop

[mergify]

backport develop

✅ Backports have been created

• #29417 fix: barcode is always deleted and inserted each time an item is saved (backport #29411) has been created for branch develop