Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: enable allow negative stock by default in reposts #29331

Merged
merged 1 commit into from
Jan 18, 2022
Merged

fix: enable allow negative stock by default in reposts #29331

merged 1 commit into from
Jan 18, 2022

Conversation

ankush
Copy link
Member

@ankush ankush commented Jan 18, 2022

Negative stock validation is done BEFORE reposting as such it's not
required to be performed again and most likely this fails on old
intermediate data where user has no clue why it failed.

@ankush
fix: enable allow negative stock by default in reposts
6a6c475 
Negative stock validation is done BEFORE reposting as such it's not
required to be performed again and most likely this fails on old
intermediate data where user has no clue why it failed.
@ankush ankush added Skip Manual Testing The changes in this PR does not require manual testing backport version-13-hotfix labels Jan 18, 2022
@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Jan 18, 2022
@ankush ankush removed the needs-tests This PR needs automated unit-tests. label Jan 18, 2022
@codecov
Copy link

codecov bot commented Jan 18, 2022

Codecov Report

Merging #29331 (6a6c475) into develop (48f3d53) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop   #29331      +/-   ##
===========================================
+ Coverage    57.91%   57.94%   +0.03%     
===========================================
  Files         1110     1110              
  Lines        68091    68091              
===========================================
+ Hits         39435    39458      +23     
+ Misses       28656    28633      -23
Impacted Files Coverage Δ
...ype/repost_item_valuation/repost_item_valuation.py 64.16% <100.00%> (ø)
.../report/bom_operations_time/bom_operations_time.py 93.33% <0.00%> (-3.34%) ⬇️
erpnext/assets/doctype/asset/depreciation.py 85.23% <0.00%> (-2.69%) ⬇️
...value/warehouse_wise_item_balance_age_and_value.py 92.40% <0.00%> (-2.54%) ⬇️
erpnext/stock/report/stock_ageing/stock_ageing.py 91.32% <0.00%> (-2.32%) ⬇️
.../report/stock_projected_qty/stock_projected_qty.py 88.15% <0.00%> (-1.32%) ⬇️
erpnext/accounts/deferred_revenue.py 75.32% <0.00%> (-0.87%) ⬇️
erpnext/stock/report/stock_ledger/stock_ledger.py 77.23% <0.00%> (-0.82%) ⬇️
erpnext/selling/doctype/quotation/quotation.py 49.18% <0.00%> (-0.55%) ⬇️
erpnext/selling/doctype/sales_order/sales_order.py 77.29% <0.00%> (-0.39%) ⬇️
... and 18 more

@ankush ankush merged commit fabe0bc into frappe:develop Jan 18, 2022
@ankush ankush deleted the repost_defaults branch January 18, 2022 06:19
mergify bot pushed a commit that referenced this pull request Jan 18, 2022
@ankush
fix: enable allow negative stock by default in reposts (#29331)
6842f39 
Negative stock validation is done BEFORE reposting as such it's not
required to be performed again and most likely this fails on old
intermediate data where user has no clue why it failed.

(cherry picked from commit fabe0bc)
@mergify mergify bot mentioned this pull request Jan 18, 2022
Merged
ankush added a commit that referenced this pull request Jan 18, 2022
@mergify @ankush
fix: enable allow negative stock by default in reposts (#29331) (#29333)
69fded2 
Negative stock validation is done BEFORE reposting as such it's not
required to be performed again and most likely this fails on old
intermediate data where user has no clue why it failed.

(cherry picked from commit fabe0bc)

Co-authored-by: Ankush Menat <ankush@frappe.io>
@ankush ankush removed the Skip Manual Testing The changes in this PR does not require manual testing label Mar 9, 2022
KrithiRamani pushed a commit to KrithiRamani/erpnext that referenced this pull request Mar 14, 2022
@mergify @ankush @KrithiRamani
fix: enable allow negative stock by default in reposts (frappe#29331) (…
bca83fe 
…frappe#29333)

Negative stock validation is done BEFORE reposting as such it's not
required to be performed again and most likely this fails on old
intermediate data where user has no clue why it failed.

(cherry picked from commit fabe0bc)

Co-authored-by: Ankush Menat <ankush@frappe.io>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@marination marination Awaiting requested review from marination

@rohitwaghchaure rohitwaghchaure Awaiting requested review from rohitwaghchaure rohitwaghchaure is a code owner

Assignees
No one assigned
Labels
backport version-13-hotfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ankush