-
Notifications
You must be signed in to change notification settings - Fork 7.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: additional doctypes access for ESS user #29317
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #29317 +/- ##
===========================================
+ Coverage 58.46% 58.48% +0.01%
===========================================
Files 1091 1091
Lines 67881 67881
===========================================
+ Hits 39689 39698 +9
+ Misses 28192 28183 -9
|
@Mergifyio backport version-14-beta-pre-release |
mergify bot
pushed a commit
that referenced
this pull request
Jan 29, 2022
(cherry picked from commit 6c1c85b)
✅ Backports have been created
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional doctypes access for ESS User
no-docs
Depends on: frappe/frappe#15707
Not adding tests, it's just a default configuration change
To test:
Check if a user with Employee Self Service role is able to access these doctypes with relevant permissions:
erpnext/erpnext/setup/install.py
Lines 207 to 233 in 6c1c85b