Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pos): numpad error when changing language #29181

Closed
wants to merge 4 commits into from

Conversation

rpineda
Copy link

@rpineda rpineda commented Jan 7, 2022

The pull request fixes a small bug that happens on the POS page when the language is changed. Everything works perfect in English, but for example in Spanish. When clicking on the Quantity buttons, the event should change the focus to the input tag qty, but that does not happen.

For this reason I made a small modification in the files:

  • erpnext / selling / page / point_of_sale / pos_item_cart.js
  • erpnext / selling / page / point_of_sale / pos_number_pad.js

Modification in the file: erpnext / selling / page / point_of_sale / pos_payment.js fixes the error when choosing a customer

Please provide enough information so that others can review your pull request:

Explain the details for making this change. What existing problem does the pull request solve?

Screenshots/GIFs

…of the numpad Quantity, Discount, Rate, Remove, Delete.
…of the numpad Quantity, Discount, Rate, Remove, Delete.
@nextchamp-saqib nextchamp-saqib changed the title Numpad error when changing language fix(pos): numpad error when changing language Jan 7, 2022
@stale
Copy link

stale bot commented Jan 28, 2022

This pull request has been automatically marked as inactive because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.

@stale stale bot added the inactive label Jan 28, 2022
@nextchamp-saqib
Copy link
Member

Keep Alive

@stale stale bot removed the inactive label Jan 28, 2022
@rpineda
Copy link
Author

rpineda commented Feb 7, 2022

Keep Alive x2

@stale
Copy link

stale bot commented Feb 22, 2022

This pull request has been automatically marked as inactive because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.

@zulnabil
Copy link

this bug still exist in Indonesia language

@nextchamp-saqib
Copy link
Member

nextchamp-saqib commented May 9, 2022

Fixed with #30808

@stale stale bot removed the inactive label May 9, 2022
@github-actions github-actions bot removed the POS label May 9, 2022
@tbe
Copy link

tbe commented Oct 28, 2022

This issue still exists for me with erpnext v13.40.2 docker images.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants