-
Notifications
You must be signed in to change notification settings - Fork 7.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: Removed hospitality domain from ERPNext #29167
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #29167 +/- ##
===========================================
- Coverage 58.06% 57.77% -0.30%
===========================================
Files 1110 1091 -19
Lines 68067 67842 -225
===========================================
- Hits 39523 39195 -328
- Misses 28544 28647 +103
|
@ChillarAnand please port warning to v13. |
'Hotel Manager', | ||
'Hotel Reservation User' | ||
], | ||
'custom_fields': { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These custom fields should also be deleted in the patch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
raised PR: #29382
@ruchamahabal @ChillarAnand
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @ankush
Added this point to the checklist as well. https://frappe.io/handbook/splitting-modules @ruchamahabal
Raised PR at #29384. |
We are moving Hospitality in to a separate app. New app is available at https://github.com/frappe/hospitality.
Please raise new issues/PRs related to hospitality at the new repo.