-
Notifications
You must be signed in to change notification settings - Fork 7.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: Remove non-profit domain from ERPNext #29151
Conversation
c4bfdd9
to
024e40c
Compare
024e40c
to
0c0a9ed
Compare
606ac24
to
7086d3f
Compare
Codecov Report
@@ Coverage Diff @@
## develop #29151 +/- ##
===========================================
+ Coverage 41.62% 49.62% +7.99%
===========================================
Files 1109 1083 -26
Lines 69188 68324 -864
===========================================
+ Hits 28802 33906 +5104
+ Misses 40386 34418 -5968
|
In ERPNext, Regional is a module by itself. Regional setup is taking caring of all relevant doctypes and their setup. For Non profit, if we create cc @gavindsouza |
Just move Tax Exemption 80G Certificate to Non-Profit module. No need to create a separate module. |
The handling required during separation for things added in this PR: https://github.com/frappe/erpnext/pull/24657/files
|
b447cdc
to
d1c7341
Compare
d1c7341
to
325dc92
Compare
246bb1b
to
98f6f98
Compare
98f6f98
to
b5ff9b2
Compare
Rest, LGTM |
We are moving Non Profit domain in to a separate app. New app is available at https://github.com/frappe/non_profit.
Please raise new issues/PRs related to non-profit at the new repo.