Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: from time and to time not updated in drag and drop action #29114

Merged
merged 3 commits into from
Jan 12, 2022

Conversation

mohammedyusufshaikh
Copy link
Contributor

Before Fix:

The Course Schedule Calendar did not update from time and to time when a drag and drop action is performed in time slots of a day
drag_and_drop_in_time_slots

After Fix:

from time and to time updated correctly so new changes are saved

drag_and_drop_in_time_slots_fix

This issue was identified from here GitHub Issue

There is also a bug identified from this issue which doesn't allow user to drag and drop events to a different date which required a fix in the framework. A PR has been raised for the same #15509

@codecov
Copy link

codecov bot commented Jan 3, 2022

Codecov Report

Merging #29114 (3927c37) into develop (b8c212a) will increase coverage by 11.44%.
The diff coverage is 37.50%.

@@             Coverage Diff              @@
##           develop   #29114       +/-   ##
============================================
+ Coverage    46.54%   57.99%   +11.44%     
============================================
  Files         1128     1110       -18     
  Lines        67333    68007      +674     
============================================
+ Hits         31341    39441     +8100     
+ Misses       35992    28566     -7426     
Impacted Files Coverage Δ
erpnext/education/api.py 33.51% <ø> (+13.62%) ⬆️
...ucation/doctype/course_schedule/course_schedule.py 83.33% <37.50%> (-13.22%) ⬇️
...e/asset_value_adjustment/asset_value_adjustment.py 86.04% <0.00%> (-3.49%) ⬇️
...ctype/woocommerce_settings/woocommerce_settings.py 80.76% <0.00%> (-3.24%) ⬇️
erpnext/accounts/doctype/party_link/party_link.py 84.00% <0.00%> (-1.72%) ⬇️
erpnext/crm/doctype/opportunity/opportunity.py 70.69% <0.00%> (-0.46%) ⬇️
...ent/doctype/loan_disbursement/loan_disbursement.py 71.42% <0.00%> (-0.27%) ⬇️
erpnext/utilities/transaction_base.py 75.20% <0.00%> (-0.21%) ⬇️
erpnext/hooks.py 0.00% <0.00%> (ø)
erpnext/setup/install.py 0.00% <0.00%> (ø)
... and 389 more

@ankush ankush merged commit 8b5827e into frappe:develop Jan 12, 2022
mergify bot pushed a commit that referenced this pull request Jan 19, 2022
fix: from time and to time not updated in drag and drop action
(cherry picked from commit 8b5827e)
ankush pushed a commit that referenced this pull request Jan 19, 2022
…#29361)

fix: from time and to time not updated in drag and drop action
(cherry picked from commit 8b5827e)

Co-authored-by: Mohammed Yusuf Shaikh <49878143+mohammedyusufshaikh@users.noreply.github.com>
KrithiRamani pushed a commit to KrithiRamani/erpnext that referenced this pull request Mar 14, 2022
…#29114 (frappe#29361)

fix: from time and to time not updated in drag and drop action
(cherry picked from commit 8b5827e)

Co-authored-by: Mohammed Yusuf Shaikh <49878143+mohammedyusufshaikh@users.noreply.github.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drag and drop function doesn't work in Course Schedule Calendar
2 participants