-
Notifications
You must be signed in to change notification settings - Fork 7.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: from time and to time not updated in drag and drop action #29114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #29114 +/- ##
============================================
+ Coverage 46.54% 57.99% +11.44%
============================================
Files 1128 1110 -18
Lines 67333 68007 +674
============================================
+ Hits 31341 39441 +8100
+ Misses 35992 28566 -7426
|
ankush
reviewed
Jan 11, 2022
erpnext/education/doctype/course_schedule/course_schedule_calendar.js
Outdated
Show resolved
Hide resolved
ankush
reviewed
Jan 11, 2022
erpnext/education/doctype/course_schedule/course_schedule_calendar.js
Outdated
Show resolved
Hide resolved
mergify bot
pushed a commit
that referenced
this pull request
Jan 19, 2022
fix: from time and to time not updated in drag and drop action (cherry picked from commit 8b5827e)
ankush
pushed a commit
that referenced
this pull request
Jan 19, 2022
KrithiRamani
pushed a commit
to KrithiRamani/erpnext
that referenced
this pull request
Mar 14, 2022
…#29114 (frappe#29361) fix: from time and to time not updated in drag and drop action (cherry picked from commit 8b5827e) Co-authored-by: Mohammed Yusuf Shaikh <49878143+mohammedyusufshaikh@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before Fix:
The Course Schedule Calendar did not update from time and to time when a drag and drop action is performed in time slots of a day

After Fix:
from time and to time updated correctly so new changes are saved
This issue was identified from here GitHub Issue
There is also a bug identified from this issue which doesn't allow user to drag and drop events to a different date which required a fix in the framework. A PR has been raised for the same #15509