Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(e-commerce)(UX): shopping cart qty badge #29077

Merged

Conversation

dj12djdjs
Copy link
Collaborator

Having a fixed width assigned to shopping cart badge causes 3 digit cart qty to not be displayed properly.

Before PR
shopping-cart-before

After PR
shopping-cart-after

@marination marination self-assigned this Dec 30, 2021
@marination marination added the e-commerce-fix E-commerce PRs that need to be front ported to develop label Dec 30, 2021
@stale
Copy link

stale bot commented Jan 15, 2022

This pull request has been automatically marked as inactive because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.

@stale stale bot added the inactive label Jan 15, 2022
@stale stale bot removed the inactive label Jan 17, 2022
@marination marination merged commit 1f099bc into frappe:version-13-hotfix Jan 21, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
e-commerce-fix E-commerce PRs that need to be front ported to develop
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants