perf: remove forcing of posting sort index on stock balance report #28902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mysql is generally smart enough to figure out which index is better based on cardinality of index. While posting sort index is better for low item high # of SLE scenario it's bad for high item variety each with lower count of SLEs.
Codecov Report
@@ Coverage Diff @@
## develop #28902 +/- ##
===========================================
- Coverage 55.59% 55.56% -0.03%
===========================================
Files 1126 1126
Lines 67191 67191
===========================================
- Hits 37352 37337 -15
- Misses 29839 29854 +15
|
mergify bot
pushed a commit
that referenced
this pull request
Dec 15, 2021
mysql is generally smart enough to figure out which index is better based on cardinality of index. While posting sort index is better for low item high # of SLE scenario it's bad for high item variety each with lower count of SLEs. (cherry picked from commit 228e011)
ankush
added a commit
that referenced
this pull request
Dec 15, 2021
…28904) mysql is generally smart enough to figure out which index is better based on cardinality of index. While posting sort index is better for low item high # of SLE scenario it's bad for high item variety each with lower count of SLEs. (cherry picked from commit 228e011) Co-authored-by: Ankush Menat <ankush@frappe.io>
conncampbell
pushed a commit
to conncampbell/erpnext
that referenced
this pull request
Jan 9, 2022
…8902) mysql is generally smart enough to figure out which index is better based on cardinality of index. While posting sort index is better for low item high # of SLE scenario it's bad for high item variety each with lower count of SLEs.
conncampbell
pushed a commit
to conncampbell/erpnext
that referenced
this pull request
Jan 9, 2022
…8902) mysql is generally smart enough to figure out which index is better based on cardinality of index. While posting sort index is better for low item high # of SLE scenario it's bad for high item variety each with lower count of SLEs.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mysql is generally smart enough to figure out which index is better
based on cardinality of index. While posting sort index is better when there are too many SLEs of same items; it's bad when there are many many item-WH combos each with comparatively less SLE count.
Now we have another index: item_wh which could be better than posting_sort index in some cases. So, let MySQL pick whatever it feels is best.