Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: no module named 'redisearch' #28818

Merged
merged 6 commits into from
Dec 10, 2021
Merged

fix: no module named 'redisearch' #28818

merged 6 commits into from
Dec 10, 2021

Conversation

rtdany10
Copy link
Contributor

@rtdany10 rtdany10 commented Dec 10, 2021 •
edited
Loading

This PR aims to fix the module not found error while installing ERPNext.
Objectives:

  • Rename erpnext/e_commerce/redisearch.py
  • Rename its references

Closes #28730

@rtdany10 rtdany10 requested a review from marination as a code owner December 10, 2021 11:18
@rtdany10 rtdany10 closed this Dec 10, 2021
@rtdany10 rtdany10 deleted the patch-6 branch December 10, 2021 11:19
@rtdany10 rtdany10 restored the patch-6 branch December 10, 2021 11:22
@rtdany10 rtdany10 reopened this Dec 10, 2021
@rtdany10
Copy link
Contributor Author

@ankush Couldn't find anymore references.
cc @NagariaHussain @marination

@NagariaHussain
Copy link
Member

Congrats and Thanks for the PR! @rtdany10

@ankush ankush added the squash Meant to tell reviewers that this PR should be squashed into a single commit while merging. label Dec 10, 2021
@rtdany10
Copy link
Contributor Author

Congrats and Thanks for the PR! @rtdany10

Glad to contribute! :)
I barely scratch the surface, you guys are the real heroes! 😃

@ankush ankush linked an issue Dec 10, 2021 that may be closed by this pull request
Error: No module named 'redisearch' while installing ERPNext. #28730
Closed
@ankush ankush merged commit 3f686a6 into frappe:version-13-hotfix Dec 10, 2021
@ankush ankush added the e-commerce-fix E-commerce PRs that need to be front ported to develop label Dec 10, 2021
@barredterra barredterra mentioned this pull request Dec 10, 2021
Open
marination pushed a commit to marination/erpnext that referenced this pull request Feb 1, 2022
@rtdany10 @marination
fix: no module named 'redisearch' (frappe#28818)
d4c74b5 
* chore: rename file to avoid the overriding

* fix: rename ref frappe#1

* fix: rename ref in e_commerce_settings

* fix: rename ref in product_search.py

* chore: rename rsearch.py to redisearch_utils.py

* chore: rename rsearch to redisearch_utils in product_search
mergify bot pushed a commit that referenced this pull request Feb 3, 2022
@rtdany10
fix: no module named 'redisearch' (#28818)
3cd60c9 
* chore: rename file to avoid the overriding

* fix: rename ref #1

* fix: rename ref in e_commerce_settings

* fix: rename ref in product_search.py

* chore: rename rsearch.py to redisearch_utils.py

* chore: rename rsearch to redisearch_utils in product_search

(cherry picked from commit d4c74b5)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@NagariaHussain NagariaHussain NagariaHussain left review comments

@ankush ankush ankush approved these changes

@marination marination Awaiting requested review from marination

Assignees
No one assigned
Labels
e-commerce-fix E-commerce PRs that need to be front ported to develop squash Meant to tell reviewers that this PR should be squashed into a single commit while merging.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error: No module named 'redisearch' while installing ERPNext.
3 participants
@rtdany10 @NagariaHussain @ankush