-
Notifications
You must be signed in to change notification settings - Fork 7.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(KSA VAT): QR Code as per ZATKA specification #28605
Merged
deepeshgarg007
merged 5 commits into
frappe:develop
from
deepeshgarg007:ksa-e-invoice-new
Nov 29, 2021
Merged
refactor(KSA VAT): QR Code as per ZATKA specification #28605
deepeshgarg007
merged 5 commits into
frappe:develop
from
deepeshgarg007:ksa-e-invoice-new
Nov 29, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #28605 +/- ##
===========================================
- Coverage 55.28% 55.21% -0.07%
===========================================
Files 1120 1120
Lines 66664 66709 +45
===========================================
- Hits 36856 36835 -21
- Misses 29808 29874 +66
|
@Mergifyio backport version-13-hotfix |
@Mergifyio backport version-13-pre-release |
🟠 Waiting for conditions to match
|
🟠 Waiting for conditions to match
|
✅ Backports have been created
|
✅ Backports have been created
|
deepeshgarg007
added a commit
that referenced
this pull request
Nov 29, 2021
…se/pr-28605 refactor(KSA VAT): QR Code as per ZATKA specification (backport #28605)
deepeshgarg007
added a commit
that referenced
this pull request
Nov 29, 2021
…-28605 refactor(KSA VAT): QR Code as per ZATKA specification (backport #28605)
@deepeshgarg007 please note that there's a typo in seller's name it says "saller's name" |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verified using the following app:
Play store
https://play.google.com/store/apps/details?id=com.posbankbh.einvoiceqrreader
App store
https://apps.apple.com/sa/app/e-invoice-qr-reader-ksa/id1580793042