-
Notifications
You must be signed in to change notification settings - Fork 7.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: update_invoice_status
with query builder
#28160
refactor: update_invoice_status
with query builder
#28160
Conversation
3008f6d
to
210dc3e
Compare
Codecov Report
@@ Coverage Diff @@
## develop #28160 +/- ##
===========================================
+ Coverage 55.68% 55.72% +0.03%
===========================================
Files 1129 1129
Lines 67471 67483 +12
===========================================
+ Hits 37574 37603 +29
+ Misses 29897 29880 -17
|
210dc3e
to
4f97ffe
Compare
update_invoice_status
with query builder
@pruthvi145, since you are at it, can also take into account the status of the invoice which are discounted. Invoice discounting is completely ignored while updating the status |
Fixed |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed within a week if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing. |
@pruthvi145 Hey, can you add a basic test for checking if the Unpaid invoice goes to Overdue state once the due date has passed? |
5920261
to
4d48ca4
Compare
Co-authored-by: Saqib <nextchamp.saqib@gmail.com>
@nextchamp-saqib added test cases. |
@Mergifyio backport version-13-hotfix |
✅ Backports have been created
|
…-28160 refactor: `update_invoice_status` with query builder (backport #28160)
Continuation of #28019
converted raw SQL Query to Query Builder for
update_invoice_status