Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: replace newline in remarks (DATEV report) #28152

Merged
merged 2 commits into from
Nov 4, 2021
Merged

fix: replace newline in remarks (DATEV report) #28152

merged 2 commits into from
Nov 4, 2021

Conversation

barredterra
Copy link
Collaborator

Remarks can contain newline ("\n"). This causes problems when exported to CSV.

Therefore we replace "\n" with " ".

@barredterra barredterra changed the title feat: replace newline in remarks (DATEV report) fix: replace newline in remarks (DATEV report) Oct 29, 2021
@codecov
Copy link

codecov bot commented Oct 29, 2021 •
edited
Loading

Codecov Report

Merging #28152 (5246935) into develop (30a6f03) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop   #28152      +/-   ##
===========================================
- Coverage    55.51%   55.47%   -0.04%     
===========================================
  Files         1248     1248              
  Lines        67756    67756              
===========================================
- Hits         37614    37588      -26     
- Misses       30142    30168      +26
Impacted Files Coverage Δ
erpnext/regional/report/datev/datev.py 85.04% <ø> (ø)
...payroll/doctype/income_tax_slab/income_tax_slab.py 85.71% <0.00%> (-14.29%) ⬇️
...t/payroll/doctype/payroll_period/payroll_period.py 65.45% <0.00%> (-5.46%) ⬇️
...eorder_level/itemwise_recommended_reorder_level.py 90.56% <0.00%> (-3.78%) ⬇️
...eport/item_variant_details/item_variant_details.py 84.52% <0.00%> (-3.58%) ⬇️
erpnext/education/doctype/student/student.py 73.95% <0.00%> (-3.13%) ⬇️
erpnext/stock/report/stock_ledger/stock_ledger.py 75.00% <0.00%> (-2.42%) ⬇️
...ion/doctype/course_enrollment/course_enrollment.py 45.09% <0.00%> (-1.97%) ⬇️
...wise_balance_history/batch_wise_balance_history.py 91.52% <0.00%> (-1.70%) ⬇️
.../report/stock_projected_qty/stock_projected_qty.py 87.01% <0.00%> (-1.30%) ⬇️
... and 13 more

@barredterra barredterra enabled auto-merge October 30, 2021 22:14
@barredterra
Copy link
Collaborator Author

@Mergifyio backport version-13-hotfix

@mergify
Copy link
Contributor

mergify bot commented Nov 4, 2021

backport version-13-hotfix

🟠 Waiting for conditions to match

  • merged [:pushpin: backport requirement]

@barredterra
Copy link
Collaborator Author

The cypress failure is not related to this PR

@ankush ankush disabled auto-merge November 4, 2021 16:14
@ankush ankush merged commit 114028e into frappe:develop Nov 4, 2021
mergify bot pushed a commit that referenced this pull request Nov 4, 2021
@barredterra
feat: replace newline in remarks (DATEV report) (#28152)
014abf5 
(cherry picked from commit 114028e)
@mergify mergify bot mentioned this pull request Nov 4, 2021
Merged
@mergify
Copy link
Contributor

mergify bot commented Nov 4, 2021

backport version-13-hotfix

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Nov 4, 2021
@barredterra
feat: replace newline in remarks (DATEV report) (#28152)
5834172 
(cherry picked from commit 114028e)
@mergify mergify bot mentioned this pull request Nov 4, 2021
Merged
@barredterra barredterra deleted the datev-replace-newline branch November 4, 2021 16:27
ankush pushed a commit that referenced this pull request Nov 5, 2021
@mergify @barredterra
feat: replace newline in remarks (DATEV report) (#28152) (#28248)
79be341 
(cherry picked from commit 114028e)

Co-authored-by: Raffael Meyer <14891507+barredterra@users.noreply.github.com>
ankush pushed a commit that referenced this pull request Nov 5, 2021
@mergify @barredterra
feat: replace newline in remarks (DATEV report) (#28152) (#28247)
4cb3c2a 
(cherry picked from commit 114028e)

Co-authored-by: Raffael Meyer <14891507+barredterra@users.noreply.github.com>
asoral pushed a commit to asoral/erpnext that referenced this pull request Nov 12, 2021
@mergify @barredterra
feat: replace newline in remarks (DATEV report) (frappe#28152) (frapp…
c85f542 
…e#28248)

(cherry picked from commit 114028e)

Co-authored-by: Raffael Meyer <14891507+barredterra@users.noreply.github.com>
@commit-lint commit-lint bot mentioned this pull request Nov 24, 2021
Merged
conncampbell pushed a commit to conncampbell/erpnext that referenced this pull request Jan 9, 2022
@barredterra
feat: replace newline in remarks (DATEV report) (frappe#28152)
c6bfa1b
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ankush ankush ankush approved these changes

@deepeshgarg007 deepeshgarg007 Awaiting requested review from deepeshgarg007

@nextchamp-saqib nextchamp-saqib Awaiting requested review from nextchamp-saqib

Assignees
No one assigned
Labels
backport version-13-hotfix regional
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@barredterra @ankush