Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: SO/Quotation Portal Missing Images #28098

Merged
merged 2 commits into from
Oct 27, 2021

Conversation

marination
Copy link
Collaborator

Issue:

  • Indicator and Actions font could be smaller
  • Missing images

Screenshot 2021-10-27 at 11 04 32 AM

- Recommendations without images were too crammed

Screenshot 2021-10-27 at 11 11 01 AM

Fix:

  • SO Portal
    Screenshot 2021-10-27 at 11 06 08 AM
  • Recommendations
    Screenshot 2021-10-27 at 11 07 58 AM

- SO Portal: fixed missing images issue
- SO Portal: fallback state when no images
- SO Portal: code indentation in `order_macros.html`
- SO Portal: Actions and indicator font size
- Recommendations: fixed space between image and title
- Recommendations: give empty image state min height
@marination marination added the e-commerce-fix E-commerce PRs that need to be front ported to develop label Oct 27, 2021
@marination marination merged commit a19f0f4 into frappe:version-13-hotfix Oct 27, 2021
asoral pushed a commit to asoral/erpnext that referenced this pull request Nov 12, 2021
fix: SO/Quotation Portal Missing Images
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
e-commerce-fix E-commerce PRs that need to be front ported to develop
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant