Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: move semgrep rules out of repo (backport #28067) #28069

Merged
merged 2 commits into from
Oct 22, 2021

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Oct 22, 2021

This is an automatic backport of pull request #28067 done by Mergify.
Cherry-pick of cc1baae has failed:

On branch mergify/bp/version-13-hotfix/pr-28067
Your branch is up to date with 'origin/version-13-hotfix'.

You are currently cherry-picking commit cc1baae5eb.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	deleted:    .github/helper/semgrep_rules/README.md
	deleted:    .github/helper/semgrep_rules/report.yml
	deleted:    .github/helper/semgrep_rules/security.py
	deleted:    .github/helper/semgrep_rules/security.yml
	deleted:    .github/helper/semgrep_rules/translate.js
	deleted:    .github/helper/semgrep_rules/translate.py
	deleted:    .github/helper/semgrep_rules/translate.yml
	deleted:    .github/helper/semgrep_rules/ux.js
	deleted:    .github/helper/semgrep_rules/ux.yml

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by them: .github/helper/semgrep_rules/frappe_correctness.py
	deleted by them: .github/helper/semgrep_rules/frappe_correctness.yml
	deleted by them: .github/helper/semgrep_rules/report.py
	deleted by them: .github/helper/semgrep_rules/ux.py
	both modified:   .github/workflows/linters.yml

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.io/

Moving semgrep rules out of repos as it's unnecessary to maintain
same ruleset for different repos and different branches.

(cherry picked from commit cc1baae)

# Conflicts:
#	.github/helper/semgrep_rules/frappe_correctness.py
#	.github/helper/semgrep_rules/frappe_correctness.yml
#	.github/helper/semgrep_rules/report.py
#	.github/helper/semgrep_rules/ux.py
#	.github/workflows/linters.yml
@ankush ankush merged commit a082d70 into version-13-hotfix Oct 22, 2021
@ankush ankush deleted the mergify/bp/version-13-hotfix/pr-28067 branch October 22, 2021 16:28
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant