ci: move semgrep rules out of repo #28067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4d017bc to
752e527
Compare
Moving semgrep rules out of repos as it's unnecessary to maintain same ruleset for different repos and different branches.
mergify bot
pushed a commit
that referenced
this pull request
Oct 22, 2021
Moving semgrep rules out of repos as it's unnecessary to maintain same ruleset for different repos and different branches. (cherry picked from commit cc1baae) # Conflicts: # .github/helper/semgrep_rules/frappe_correctness.py # .github/helper/semgrep_rules/frappe_correctness.yml # .github/helper/semgrep_rules/report.py # .github/helper/semgrep_rules/ux.py # .github/workflows/linters.yml
ankush
added a commit
that referenced
this pull request
Oct 22, 2021
* ci: move semgrep rules out of repo (#28067) Moving semgrep rules out of repos as it's unnecessary to maintain same ruleset for different repos and different branches. (cherry picked from commit cc1baae) # Conflicts: # .github/helper/semgrep_rules/frappe_correctness.py # .github/helper/semgrep_rules/frappe_correctness.yml # .github/helper/semgrep_rules/report.py # .github/helper/semgrep_rules/ux.py # .github/workflows/linters.yml * fix: resolve conflicts Co-authored-by: Ankush Menat <ankush@frappe.io>
asoral
pushed a commit
to asoral/erpnext
that referenced
this pull request
Nov 12, 2021
* ci: move semgrep rules out of repo (frappe#28067) Moving semgrep rules out of repos as it's unnecessary to maintain same ruleset for different repos and different branches. (cherry picked from commit cc1baae) # Conflicts: # .github/helper/semgrep_rules/frappe_correctness.py # .github/helper/semgrep_rules/frappe_correctness.yml # .github/helper/semgrep_rules/report.py # .github/helper/semgrep_rules/ux.py # .github/workflows/linters.yml * fix: resolve conflicts Co-authored-by: Ankush Menat <ankush@frappe.io>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving semgrep rules out of repos as it's unnecessary to maintain same ruleset for different repos and different branches.
Step 1/n in having a consistent reusable CI system for Frappe apps 😄