Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fetch thumbnail from Item master instead of regenerating #28005

Merged
merged 5 commits into from
Oct 20, 2021
Merged

fix: Fetch thumbnail from Item master instead of regenerating #28005

merged 5 commits into from
Oct 20, 2021

Conversation

marination
Copy link
Collaborator

@marination marination commented Oct 19, 2021 •
edited
Loading

Issue:

  • Due to thumbnail generation in patch, patch slowed down a lot. File is created , etc. which slows things down

Fix:

  • Separate patch to update thumbnail field of website item from item master
  • In create_website_items, only make web items, nothing else. If web item exists, skip the item.
  • Added a progress bar to create_website_items

@marination marination added the e-commerce-fix E-commerce PRs that need to be front ported to develop label Oct 19, 2021
@marination
fix: re-run patch
11c498d 
- Patch will just fetch thumbnails if website items are created, else it will create new website items
@marination
fix: Get db values as dict when checking for thumbnail in existing we…
46a5a83 
…b item
@marination
fix: Check if thumbnail column exists in case of table trimming
ac8014e
@marination
fix: Move thumbnail updation to different patch
348a961 
- Thumbnail updation handled via different patch
- create_website_items will only have one purpose
- added progress bar to `create_website_items`
- code cleanup
@marination marination force-pushed the patch-thumbnail-perf branch from ddf6b8f to 348a961 Compare October 20, 2021 08:44
@marination
Copy link
Collaborator Author

@Mergifyio backport version-13-pre-release

@mergify
Copy link
Contributor

mergify bot commented Oct 20, 2021 •
edited by marination
Loading

backport version-13-pre-release

🟠 Waiting for conditions

  • merged [:pushpin: backport requirement]

@marination marination merged commit 077026a into frappe:version-13-hotfix Oct 20, 2021
@mergify mergify bot mentioned this pull request Oct 20, 2021
Merged
@mergify
Copy link
Contributor

mergify bot commented Oct 20, 2021

backport version-13-pre-release

✅ Backports have been created

marination added a commit that referenced this pull request Oct 20, 2021
@marination
Merge pull request #28021 from frappe/mergify/bp/version-13-pre-relea…
e0decb0 
…se/pr-28005

fix: Fetch thumbnail from Item master instead of regenerating (backport #28005)
@rohitwaghchaure rohitwaghchaure mentioned this pull request Nov 9, 2021
Merged
asoral pushed a commit to asoral/erpnext that referenced this pull request Nov 12, 2021
@marination
Merge pull request frappe#28005 from marination/patch-thumbnail-perf
da95fc6 
fix: Fetch thumbnail from Item master instead of regenerating
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
e-commerce-fix E-commerce PRs that need to be front ported to develop
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@marination