Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: map missing fields in opportunity #27904

Merged
merged 2 commits into from
Oct 20, 2021
Merged

fix: map missing fields in opportunity #27904

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2740dad
fix: map missing fields in opportunity
pateljannat Oct 11, 2021
1988f20
Merge branch 'develop' into opportunity-field-map
pateljannat Oct 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions erpnext/crm/doctype/opportunity/opportunity.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ def validate(self):
self.validate_item_details()
self.validate_uom_is_integer("uom", "qty")
self.validate_cust_name()
self.map_fields()

if not self.title:
self.title = self.customer_name
Expand All @@ -43,6 +44,15 @@ def validate(self):
else:
self.calculate_totals()

def map_fields(self):
for field in self.meta.fields:
if not self.get(field.fieldname):
try:
value = frappe.db.get_value(self.opportunity_from, self.party_name, field.fieldname)
frappe.db.set(self, field.fieldname, value)
except Exception:
continue

def calculate_totals(self):
total = base_total = 0
for item in self.get('items'):
Expand Down