Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add cost center in gl entry for advance payment entry #27840

Conversation

AfshanKhan
Copy link
Contributor

Problem:

When allocating advance payment in sales invoice and submitting it creates GL without cost center mentioned in sales invoice.
Because of this when checking Accounts Receivable Reports with a filter of cost center gives the paid sales invoice showing outstanding balance.

Steps to replicate:

  1. Make a payment entry for a customer.
  2. Now make a Sales Invoice with a cost center for that customer and allocate advance as the payment that was created.
  3. After submitting Sales Invoice check Accounts Receivable Reports and add that cost center in filters.
  4. The Sales invoice even thought it is paid is shown as one containing outstanding balance.

@codecov
Copy link

codecov bot commented Oct 6, 2021

Codecov Report

Merging #27840 (868abf5) into develop (4bbe434) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop   #27840      +/-   ##
===========================================
- Coverage    54.48%   54.46%   -0.03%     
===========================================
  Files         1254     1254              
  Lines        67717    67720       +3     
===========================================
- Hits         36893    36881      -12     
- Misses       30824    30839      +15     
Impacted Files Coverage Δ
...xt/accounts/doctype/payment_entry/payment_entry.py 69.67% <100.00%> (+0.08%) ⬆️
...t/payroll/doctype/payroll_period/payroll_period.py 65.45% <0.00%> (-5.46%) ⬇️
erpnext/education/doctype/student/student.py 73.95% <0.00%> (-3.13%) ⬇️
erpnext/stock/reorder_item.py 74.57% <0.00%> (-2.55%) ⬇️
...ion/doctype/course_enrollment/course_enrollment.py 45.09% <0.00%> (-1.97%) ⬇️
erpnext/stock/stock_ledger.py 85.40% <0.00%> (-1.63%) ⬇️
.../report/stock_projected_qty/stock_projected_qty.py 88.31% <0.00%> (-1.30%) ⬇️
erpnext/payroll/doctype/salary_slip/salary_slip.py 83.42% <0.00%> (-0.81%) ⬇️
erpnext/accounts/utils.py 59.38% <0.00%> (+0.18%) ⬆️
...stock/doctype/purchase_receipt/purchase_receipt.py 90.61% <0.00%> (+0.26%) ⬆️
... and 5 more

@AfshanKhan
Copy link
Contributor Author

@Mergifyio backport version-13-hotfix

@mergify
Copy link
Contributor

mergify bot commented Oct 11, 2021

Command backport version-13-hotfix: pending

backport version-13-hotfix is pending

@nextchamp-saqib nextchamp-saqib merged commit 569dc5f into frappe:develop Oct 12, 2021
mergify bot pushed a commit that referenced this pull request Oct 12, 2021
@mergify
Copy link
Contributor

mergify bot commented Oct 12, 2021

Command backport version-13-hotfix: success

Backports have been created

AfshanKhan added a commit that referenced this pull request Oct 12, 2021
…27915)

(cherry picked from commit 569dc5f)

Co-authored-by: Afshan <33727827+AfshanKhan@users.noreply.github.com>
asoral pushed a commit to asoral/erpnext that referenced this pull request Nov 12, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants