-
Notifications
You must be signed in to change notification settings - Fork 7.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add cost center in gl entry for advance payment entry #27840
Merged
nextchamp-saqib
merged 3 commits into
frappe:develop
from
AfshanKhan:fix-cost-center-for-advance-via-sales-invoice
Oct 12, 2021
Merged
fix: add cost center in gl entry for advance payment entry #27840
nextchamp-saqib
merged 3 commits into
frappe:develop
from
AfshanKhan:fix-cost-center-for-advance-via-sales-invoice
Oct 12, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #27840 +/- ##
===========================================
- Coverage 54.48% 54.46% -0.03%
===========================================
Files 1254 1254
Lines 67717 67720 +3
===========================================
- Hits 36893 36881 -12
- Misses 30824 30839 +15
|
@Mergifyio backport version-13-hotfix |
Command
|
nextchamp-saqib
approved these changes
Oct 12, 2021
mergify bot
pushed a commit
that referenced
this pull request
Oct 12, 2021
(cherry picked from commit 569dc5f)
Command
|
AfshanKhan
added a commit
that referenced
this pull request
Oct 12, 2021
asoral
pushed a commit
to asoral/erpnext
that referenced
this pull request
Nov 12, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
When allocating advance payment in sales invoice and submitting it creates GL without cost center mentioned in sales invoice.
Because of this when checking Accounts Receivable Reports with a filter of cost center gives the paid sales invoice showing outstanding balance.
Steps to replicate: