-
Notifications
You must be signed in to change notification settings - Fork 7.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Clean up mutable defaults and add CI check #27828
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
eaa0704
to
3f294ad
Compare
ankush
requested changes
Oct 6, 2021
Codecov Report
@@ Coverage Diff @@
## develop #27828 +/- ##
============================================
+ Coverage 0 54.53% +54.53%
============================================
Files 0 1248 +1248
Lines 0 67544 +67544
============================================
+ Hits 0 36834 +36834
- Misses 0 30710 +30710
|
ankush
reviewed
Oct 6, 2021
erpnext/accounts/doctype/promotional_scheme/promotional_scheme.py
Outdated
Show resolved
Hide resolved
ankush
approved these changes
Oct 6, 2021
mergify bot
pushed a commit
that referenced
this pull request
Oct 6, 2021
* refactor: Clean up mutable defaults and add CI check (cherry picked from commit 772d475)
ankush
pushed a commit
that referenced
this pull request
Oct 7, 2021
asoral
pushed a commit
to asoral/erpnext
that referenced
this pull request
Nov 12, 2021
* refactor: Clean up mutable defaults and add CI check
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.