Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: restore inadvertently removed function calculate_total_billing_amount #27694

Closed
wants to merge 1 commit into from
Closed

fix: restore inadvertently removed function calculate_total_billing_amount #27694

wants to merge 1 commit into from

Conversation

sagarvora
Copy link
Collaborator

calculate_total_billing_amount was inadvertently removed here, although it is still being used whenever the currency event is triggered.

image

@ankush
Copy link
Member

ankush commented Oct 1, 2021

Looks like it was removed intentionally. The commit message is misleading 😅

b57521a

@sagarvora sagarvora closed this Oct 2, 2021
@sagarvora
Copy link
Collaborator Author

@ankush,

Thanks for the feedback!

This has been properly fixed here.

@sagarvora sagarvora mentioned this pull request Oct 2, 2021
Merged
@mergify mergify bot mentioned this pull request Feb 18, 2025
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@deepeshgarg007 deepeshgarg007 Awaiting requested review from deepeshgarg007 deepeshgarg007 is a code owner

@nextchamp-saqib nextchamp-saqib Awaiting requested review from nextchamp-saqib

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sagarvora @ankush