-
Notifications
You must be signed in to change notification settings - Fork 7.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: cannot set custom label for 'total' field in print format #27664
Merged
nextchamp-saqib
merged 1 commit into
frappe:develop
from
nextchamp-saqib:fix-totals-label
Sep 27, 2021
Merged
fix: cannot set custom label for 'total' field in print format #27664
nextchamp-saqib
merged 1 commit into
frappe:develop
from
nextchamp-saqib:fix-totals-label
Sep 27, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@Mergifyio backport enterprise-hotfix |
Command
|
Codecov Report
@@ Coverage Diff @@
## develop #27664 +/- ##
===========================================
+ Coverage 54.49% 54.52% +0.03%
===========================================
Files 1333 1333
Lines 70736 70740 +4
===========================================
+ Hits 38545 38574 +29
+ Misses 32191 32166 -25
|
@Mergifyio backport version-13-hotfix |
mergify bot
pushed a commit
that referenced
this pull request
Sep 27, 2021
(cherry picked from commit f2fca59)
Command
|
mergify bot
pushed a commit
that referenced
this pull request
Sep 27, 2021
(cherry picked from commit f2fca59)
Command
|
asoral
pushed a commit
to asoral/erpnext
that referenced
this pull request
Nov 12, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'Total' field is rendered with a custom template in Sales Invoice print formats.
The template fetches the label from meta, which required users to change the label from the Customize Form to change the label in print format
To test the fix: