Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: comment about coverage after min. 3 builds #27544

Merged
merged 1 commit into from
Sep 16, 2021

Conversation

ankush
Copy link
Member

@ankush ankush commented Sep 16, 2021

  • Codecov is prematurely commenting with wrong/misleading coverage information.
  • Comment only after 3 build results are received.

@codecov
Copy link

codecov bot commented Sep 16, 2021

Codecov Report

Merging #27544 (0f20b0c) into develop (e6a1ad8) will increase coverage by 0.04%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop   #27544      +/-   ##
===========================================
+ Coverage    54.48%   54.53%   +0.04%     
===========================================
  Files         1333     1333              
  Lines        70696    70698       +2     
===========================================
+ Hits         38520    38555      +35     
+ Misses       32176    32143      -33     
Impacted Files Coverage Δ
erpnext/stock/stock_ledger.py 85.40% <0.00%> (-1.45%) ⬇️
erpnext/portal/utils.py 30.00% <0.00%> (-1.43%) ⬇️
erpnext/stock/reorder_item.py 75.22% <0.00%> (-0.89%) ⬇️
...ice_creation_tool/opening_invoice_creation_tool.py 60.41% <0.00%> (-0.70%) ⬇️
erpnext/hr/utils.py 72.80% <0.00%> (-0.44%) ⬇️
...ctype/stock_reconciliation/stock_reconciliation.py 82.85% <0.00%> (-0.43%) ⬇️
...cturing/doctype/production_plan/production_plan.py 69.78% <0.00%> (-0.06%) ⬇️
...ext/payroll/doctype/payroll_entry/payroll_entry.py 70.86% <0.00%> (ø)
erpnext/accounts/utils.py 59.70% <0.00%> (+0.18%) ⬆️
...stock/doctype/purchase_receipt/purchase_receipt.py 90.61% <0.00%> (+0.26%) ⬆️
... and 12 more

@ankush ankush merged commit 557d951 into frappe:develop Sep 16, 2021
@ankush ankush deleted the codecov_comment_fix branch September 16, 2021 11:47
@ankush ankush restored the codecov_comment_fix branch September 16, 2021 11:47
@ankush ankush removed the dont-merge label Sep 16, 2021
asoral pushed a commit to asoral/erpnext that referenced this pull request Nov 12, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant