Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: POS payment mode selection issue #27409

Merged
merged 1 commit into from
Sep 9, 2021
Merged

fix: POS payment mode selection issue #27409

merged 1 commit into from
Sep 9, 2021

Conversation

nemesis189
Copy link
Contributor

Problem:

  • On selecting another mode of payment it automatically selects the default mode
  • on making the value of the default mode 0 it sets the entire amount automatically

zfPOwlp

Solution:

  • Removed the part that selects the default mode automatically
  • Added snippet to select the default mode on first render after loading

@nextchamp-saqib nextchamp-saqib merged commit 8b4c57e into frappe:develop Sep 9, 2021
nextchamp-saqib pushed a commit to nextchamp-saqib/erpnext that referenced this pull request Sep 9, 2021
@nemesis189 @nextchamp-saqib
fix: pos payment mode selection issue (frappe#27409)
f6d95f5
@nextchamp-saqib nextchamp-saqib mentioned this pull request Sep 9, 2021
Merged
nextchamp-saqib added a commit that referenced this pull request Sep 9, 2021
@nextchamp-saqib
fix: pos payment mode selection issue (#27409) (#27417)
3cac39c
@rohitwaghchaure rohitwaghchaure mentioned this pull request Sep 15, 2021
Merged
sunhoww added a commit to libermatic/posx that referenced this pull request Sep 16, 2021
@sunhoww
feat: remove fix_payment_method_select
fc24eba 
superceded by frappe/erpnext#27409 and frappe/erpnext#27251
asoral pushed a commit to asoral/erpnext that referenced this pull request Nov 12, 2021
@nemesis189
fix: pos payment mode selection issue (frappe#27409)
e18cd94
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nextchamp-saqib nextchamp-saqib nextchamp-saqib approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nemesis189 @nextchamp-saqib