-
Notifications
You must be signed in to change notification settings - Fork 7.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: currency exchange settings #27318
feat: currency exchange settings #27318
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@marination @deepeshgarg007 @nextchamp-saqib @barredterra
Your comments? From UX perspective most users won't understand what endpoint/parameters etc even means. It might be a better idea to have a list of providers from which users can choose the one they want.
erpnext/setup/doctype/currency_exchange_settings/currency_exchange_settings.js
Outdated
Show resolved
Hide resolved
@ankush I agree with your solution but have a different reasoning. @rtdany10 I would also suggest giving a list of services, that we support, to choose from so that we know that these are well handled and compatible with ERPNext. We can incrementally build on these services as and when there is demand for them. |
I believe that the function to get exchange rate from the provider does handle this. It returns 0.00 and logs an error. But again, as pointed out, having some select-able pre-configured options will make it easier for the end user, like in the case of Email Accounts where certain service providers can be selected without configuring Email Domain. I can add some service providers; would be nice if someone shares a preferred list of service providers. @barredterra and other end users. |
@rtdany10 let's go with exchangerate.host and frankfurter.app for now. The official API of the European Central Bank would also be interesting: https://sdw-wsrest.ecb.europa.eu/help/ |
Codecov Report
@@ Coverage Diff @@
## develop #27318 +/- ##
===========================================
+ Coverage 48.84% 57.92% +9.07%
===========================================
Files 1107 1110 +3
Lines 67910 67991 +81
===========================================
+ Hits 33174 39386 +6212
+ Misses 34736 28605 -6131
|
CES-1.mp4I hope this is fine. Will make the fields read only. |
erpnext/accounts/doctype/currency_exchange_settings/currency_exchange_settings.js
Outdated
Show resolved
Hide resolved
This pull request has been automatically marked as inactive because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing. |
…ency-exchange-settings
…ency-exchange-settings
c357459
to
93d784d
Compare
@Mergifyio backport version-13-hotfix |
❌ No backport have been created
|
Currency Exchange Settings will enable users to use exchange rate provider of their choice.

Closes #27317
#no-docs (temp)