fix: Healthcare Service Unit fixes #27273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frappe-pr-bot
pushed a commit
to frappe-pr-bot/erpnext
that referenced
this pull request
Aug 31, 2021
* fix: validate service unit setup against practitioner schedule * fix: service unit properties getting overwritten (cherry picked from commit ef76f62)
frappe-pr-bot
pushed a commit
to frappe-pr-bot/erpnext
that referenced
this pull request
Aug 31, 2021
* fix: validate service unit setup against practitioner schedule * fix: service unit properties getting overwritten (cherry picked from commit ef76f62)
ruchamahabal
added a commit
that referenced
this pull request
Aug 31, 2021
ruchamahabal
added a commit
that referenced
this pull request
Aug 31, 2021
This was referenced Sep 1, 2021
asoral
pushed a commit
to asoral/erpnext
that referenced
this pull request
Nov 12, 2021
* fix: validate service unit setup against practitioner schedule * fix: service unit properties getting overwritten
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
If there is no Service Unit set against a Practitioner Schedule, the Availability Dialog shows undefined values:
After:
Added a Validation message for the same:
Once the service unit is set:
Before:
While creating a service unit from the tree view, data gets overwritten:
After:
Convert
is_groupvariable to int before evaluating the condition