Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Validity dates in Tax Withholding Rates #27258

Merged
merged 10 commits into from
Sep 9, 2021

Conversation

deepeshgarg007
Copy link
Member

@deepeshgarg007 deepeshgarg007 commented Aug 31, 2021

Replaced fiscal year in tax withholding rates with from and to date and patched existing records by Fiscal Year Start and End Dates

The reason for replacing this will from and to date is some categories come into effect from the mid of the fiscal year and hence only the invoices made during that period should be considered for checking threshold and not the entire fiscal year

Screenshot 2021-08-31 at 6 26 02 PM

no-docs

@coveralls
Copy link

coveralls commented Sep 9, 2021

Coverage Status

Coverage decreased (-0.0002%) to 51.666% when pulling e7e2ce1 on deepeshgarg007:tds_validity into 5596988 on frappe:develop.

@frappe-pr-bot
Copy link
Collaborator

The backport to version-13-hotfix failed.
Please backport the PR manually. 🤖

The process '/usr/bin/git' failed with exit code 1

asoral pushed a commit to asoral/erpnext that referenced this pull request Nov 12, 2021
feat: Validity dates in Tax Withholding Rates
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants