Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(payroll): Fixed issue with accessing last salary slip for new employee #27247

Merged
merged 1 commit into from
Aug 31, 2021
Merged

fix(payroll): Fixed issue with accessing last salary slip for new employee #27247

merged 1 commit into from
Aug 31, 2021

Conversation

ChillarAnand
Copy link
Contributor

@ChillarAnand ChillarAnand commented Aug 31, 2021 •
edited
Loading

For a new employee, when trying to access to last salary slip, it is failing with index error.

@ChillarAnand ChillarAnand changed the title fix(payroll): Fixed issue with accessing last salary slip for new emp… fix(payroll): Fixed issue with accessing last salary slip for new employee Aug 31, 2021
@ChillarAnand ChillarAnand marked this pull request as ready for review August 31, 2021 05:00
@coveralls
Copy link

Coverage Status

Coverage remained the same at 51.618% when pulling d5394f7 on ChillarAnand:develop into 1682402 on frappe:develop.

@ruchamahabal ruchamahabal merged commit 88d8493 into frappe:develop Aug 31, 2021
frappe-pr-bot pushed a commit to frappe-pr-bot/erpnext that referenced this pull request Aug 31, 2021
@ChillarAnand @frappe-bot
fix(payroll): Fixed issue with accessing last salary slip for new emp…
45cc1f3 
…loyee (frappe#27247)

(cherry picked from commit 88d8493)
@frappe-pr-bot frappe-pr-bot mentioned this pull request Aug 31, 2021
Merged
ruchamahabal pushed a commit that referenced this pull request Aug 31, 2021
@frappe-pr-bot @ChillarAnand
fix(payroll): Fixed issue with accessing last salary slip for new emp…
4505957 
…loyee (#27247) (#27253)

(cherry picked from commit 88d8493)

Co-authored-by: Chillar Anand <anand21nanda@gmail.com>
@rohitwaghchaure rohitwaghchaure mentioned this pull request Sep 15, 2021
Merged
asoral pushed a commit to asoral/erpnext that referenced this pull request Nov 12, 2021
@ChillarAnand
fix(payroll): Fixed issue with accessing last salary slip for new emp…
b803480 
…loyee (frappe#27247)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruchamahabal ruchamahabal ruchamahabal approved these changes

@Anurag810 Anurag810 Awaiting requested review from Anurag810

@pateljannat pateljannat Awaiting requested review from pateljannat

Assignees
No one assigned
Labels
backport version-13-hotfix payroll
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChillarAnand @coveralls @ruchamahabal