feat: color and leave type in leave application calendar #27246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pateljannat
approved these changes
Aug 31, 2021
frappe-pr-bot
pushed a commit
to frappe-pr-bot/erpnext
that referenced
this pull request
Aug 31, 2021
* feat: color and leave type in leave application calendar * fix: sider + use cstring (cherry picked from commit 366eb86)
pateljannat
pushed a commit
that referenced
this pull request
Aug 31, 2021
asoral
pushed a commit
to asoral/erpnext
that referenced
this pull request
Nov 12, 2021
… (frappe#27255) * feat: color and leave type in leave application calendar * fix: sider + use cstring (cherry picked from commit 6fd6482) Co-authored-by: Raffael Meyer <14891507+barredterra@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, a calendar event looked like this:
Everything is shown in blue, the color field in Leave Application was useless. Also you couldn't see the Leave Type.
Now it looks like this:
Leaves are shown in the color defined in Leave Application. Leave type is shown in parentheses after the employee.