Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Don't create inward SLE against SI unless is internal customer enabled #27166

Conversation

frappe-pr-bot
Copy link
Collaborator

@frappe-pr-bot frappe-pr-bot commented Aug 26, 2021

Backport f4dc9ee from #27086

…nabled (frappe#27086)

* fix: Dont create inward SLE against SI unless is internal customer enabled

- Check if is internal customer enabled apart from target warehouse
- Test to check if inward SLE is made if target warehouse is accidentally set but customer is not internal

* test: Use internal customer for delivery of bundle items to target warehouse

- created `create_internal_customer` util
- reused it in delivery note and sales invoice tests
- use internal customer for target warehouse test in delivery note

(cherry picked from commit f4dc9ee)

# Conflicts:
#	erpnext/accounts/doctype/sales_invoice/test_sales_invoice.py
@marination marination self-assigned this Aug 26, 2021
@marination
Copy link
Collaborator

Unrelated test_closing_entry failing

@marination marination merged commit 6ed5279 into frappe:version-13-hotfix Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants