feat: Accounts, Selling & Assets Onboarding cleanup #27112

kamaljohnson · 2021-08-24T13:20:10Z

feat(onboarding-cleanup): Add onboarding steps for Accounting, Assets and Selling modules

Accounting

Review Company ( show 'Company List' )

Review Chart of Accounts ( show 'Chart of Accounts' )

Setting up Taxes ( form tour for 'Sales Taxes and Charges Template' )

Account Settings ( form tour for 'Account Settings' )

Cost Centers for Budgeting and Analysis ( show 'Cost Center Tree' )

Create your first Purchase Invoice ( form tour for 'Purchase Invoice' )

Updating Opening Balances ( video tutorial )

Financial Statements ( show general report )

Assets

Review Fixed Asset Accounts ( show 'Chart of Accounts' )

Define Asset Category ( form tour for 'Asset Category' )

Create Asset Item ( form tour for 'Item' )

Purchase an Asset ( form tour for 'Purchase Receipt' )

Add an Existing Asset ( form tour for 'Asset' )

Selling

Selling Settings ( form tour for 'Selling Settings' )

Sales Order ( form tour for 'Sales Order' )

no-docs

…arding-cleanup

…ib/erpnext into onboarding_clearnup

…thod

erpnext/accounts/form_tour/purchase_invoice/purchase_invoice.json

...xt/accounts/form_tour/sales_taxes_and_charges_template/sales_taxes_and_charges_template.json

erpnext/accounts/onboarding_step/financial_statements/financial_statements.json

erpnext/assets/form_tour/asset_category/asset_category.json

erpnext/assets/onboarding_step/existing_asset/existing_asset.json

erpnext/selling/doctype/sales_order/sales_order.js

erpnext/stock/form_tour/item/item.json

Co-authored-by: Nabin Hait <nabinhait@gmail.com>

nabinhait · 2021-08-26T14:30:38Z

@kamaljohnson Errors while installing fixtures

kamaljohnson · 2021-08-26T14:48:56Z

@kamaljohnson Errors while installing fixtures

@nabinhait the local site is running fine for me, Can you please show the error.

coveralls · 2021-08-27T09:59:39Z

Coverage remained the same at 51.598% when pulling bdaf335 on kamaljohnson:onboarding_cleanup into c8f22e5 on frappe:develop.

* refactor: company form fields arrangement * refactor: accounts onboarding steps * refactor: re-arrange fields & modify labels in company form * feat: onbording steps for accounts module * fix: updated onboarding steps for selling module * fix: remove unwanted steps from accounts * feat: add more onboarding steps * feat: Refactor onboarding-module for accounting workspace * feat: Add basic asset onboarding steps * feat: Add basic asset item form tour * feat: Add basic selling onboarding-steps * feat: Add basic form tour for purchase recipt * feat: Add basic form tour for existing asset * feat: Adding asset category form tour * feat: Add form tour for asset category * feat: Refactor sales taxes and charges template form tour with new method * refactor: Remove old form tour for accounts settings * refactor: Change asset category form tour with new tour method * refactor: Change asset item form tour with new tour method * refactor: Change purchase receipt form tour with new tour method * refactor: Change asset form tour with new tour method * refactor: Remove old form tour for selling settings * refactor: general fix/typo in onboarding steps * Apply suggestions from code review Co-authored-by: Nabin Hait <nabinhait@gmail.com> * refactor: Remove old form tour method for sales order. * fix: removed duplicate section break * fix: Removed duplicate fields Co-authored-by: Saqib Ansari <nextchamp.saqib@gmail.com> Co-authored-by: Anuja <anuja.pawar20@gmail.com> Co-authored-by: Afshan <33727827+AfshanKhan@users.noreply.github.com> Co-authored-by: Nabin Hait <nabinhait@gmail.com>

nextchamp-saqib · 2021-11-22T08:59:14Z

@Mergifyio backport version-13-hotfix

* refactor: company form fields arrangement * refactor: accounts onboarding steps * refactor: re-arrange fields & modify labels in company form * feat: onbording steps for accounts module * fix: updated onboarding steps for selling module * fix: remove unwanted steps from accounts * feat: add more onboarding steps * feat: Refactor onboarding-module for accounting workspace * feat: Add basic asset onboarding steps * feat: Add basic asset item form tour * feat: Add basic selling onboarding-steps * feat: Add basic form tour for purchase recipt * feat: Add basic form tour for existing asset * feat: Adding asset category form tour * feat: Add form tour for asset category * feat: Refactor sales taxes and charges template form tour with new method * refactor: Remove old form tour for accounts settings * refactor: Change asset category form tour with new tour method * refactor: Change asset item form tour with new tour method * refactor: Change purchase receipt form tour with new tour method * refactor: Change asset form tour with new tour method * refactor: Remove old form tour for selling settings * refactor: general fix/typo in onboarding steps * Apply suggestions from code review Co-authored-by: Nabin Hait <nabinhait@gmail.com> * refactor: Remove old form tour method for sales order. * fix: removed duplicate section break * fix: Removed duplicate fields Co-authored-by: Saqib Ansari <nextchamp.saqib@gmail.com> Co-authored-by: Anuja <anuja.pawar20@gmail.com> Co-authored-by: Afshan <33727827+AfshanKhan@users.noreply.github.com> Co-authored-by: Nabin Hait <nabinhait@gmail.com> (cherry picked from commit a285b5b) # Conflicts: # erpnext/setup/doctype/company/company.json

mergify · 2021-11-22T09:00:10Z

backport version-13-hotfix

✅ Backports have been created

#28491 feat: Accounts, Selling & Assets Onboarding cleanup (backport #27112) has been created for branch version-13-hotfix

nextchamp-saqib · 2021-11-22T09:08:21Z

@Mergifyio backport version-13-pre-release

* refactor: company form fields arrangement * refactor: accounts onboarding steps * refactor: re-arrange fields & modify labels in company form * feat: onbording steps for accounts module * fix: updated onboarding steps for selling module * fix: remove unwanted steps from accounts * feat: add more onboarding steps * feat: Refactor onboarding-module for accounting workspace * feat: Add basic asset onboarding steps * feat: Add basic asset item form tour * feat: Add basic selling onboarding-steps * feat: Add basic form tour for purchase recipt * feat: Add basic form tour for existing asset * feat: Adding asset category form tour * feat: Add form tour for asset category * feat: Refactor sales taxes and charges template form tour with new method * refactor: Remove old form tour for accounts settings * refactor: Change asset category form tour with new tour method * refactor: Change asset item form tour with new tour method * refactor: Change purchase receipt form tour with new tour method * refactor: Change asset form tour with new tour method * refactor: Remove old form tour for selling settings * refactor: general fix/typo in onboarding steps * Apply suggestions from code review Co-authored-by: Nabin Hait <nabinhait@gmail.com> * refactor: Remove old form tour method for sales order. * fix: removed duplicate section break * fix: Removed duplicate fields Co-authored-by: Saqib Ansari <nextchamp.saqib@gmail.com> Co-authored-by: Anuja <anuja.pawar20@gmail.com> Co-authored-by: Afshan <33727827+AfshanKhan@users.noreply.github.com> Co-authored-by: Nabin Hait <nabinhait@gmail.com> (cherry picked from commit a285b5b) # Conflicts: # erpnext/setup/doctype/company/company.json

mergify · 2021-11-22T09:08:58Z

backport version-13-pre-release

✅ Backports have been created

#28492 feat: Accounts, Selling & Assets Onboarding cleanup (backport #27112) has been created for branch version-13-pre-release

nextchamp-saqib and others added 29 commits June 29, 2021 15:01

refactor: company form fields arrangement

9b6c8f3

refactor: accounts onboarding steps

7bfdaee

Merge branch 'develop' of https://github.com/frappe/erpnext into onbo…

ecb4ab0

…arding-cleanup

refactor: re-arrange fields & modify labels in company form

efec69e

feat: onbording steps for accounts module

ccc401d

fix: updated onboarding steps for selling module

1ad6d39

fix: remove unwanted steps from accounts

06a7b1a

feat: add more onboarding steps

df815e9

Merge branch 'develop' into onboarding-cleanup

90605fc

Merge branch 'develop' into onboarding-cleanup

4c84bac

Merge branch 'onboarding-cleanup' of https://github.com/nextchamp-saq…

0a2d8b8

…ib/erpnext into onboarding_clearnup

Merge branch 'frappe:develop' into onboarding_cleanup

7ff74b7

feat: Refactor onboarding-module for accounting workspace

3b0cb29

feat: Add basic asset onboarding steps

447fd4e

feat: Add basic asset item form tour

c1ac933

feat: Add basic selling onboarding-steps

c3cd1c7

feat: Add basic form tour for purchase recipt

81924f9

feat: Add basic form tour for existing asset

19da220

Merge branch 'frappe:develop' into onboarding_cleanup

621e316

feat: Adding asset category form tour

0a1d67d

feat: Add form tour for asset category

4cb3f77

feat: Refactor sales taxes and charges template form tour with new me…

9643db9

…thod

refactor: Remove old form tour for accounts settings

281d197

refactor: Change asset category form tour with new tour method

3df250e

refactor: Change asset item form tour with new tour method

3b94307

refactor: Change purchase receipt form tour with new tour method

4563098

refactor: Change asset form tour with new tour method

9b0afb9

refactor: Remove old form tour for selling settings

9914fd5

refactor: general fix/typo in onboarding steps

8885390

kamaljohnson requested a review from ankush as a code owner August 24, 2021 13:20

kamaljohnson requested a review from rohitwaghchaure as a code owner August 24, 2021 13:20

nabinhait requested changes Aug 25, 2021

View reviewed changes

nabinhait self-assigned this Aug 25, 2021

anupamvs added the fix-sider-issues Check and fix issues listed by Sider label Aug 25, 2021

kamaljohnson and others added 3 commits August 26, 2021 10:46

Apply suggestions from code review

b05b1ef

Co-authored-by: Nabin Hait <nabinhait@gmail.com>

refactor: Remove old form tour method for sales order.

a7929eb

Merge branch 'develop' into onboarding_cleanup

21dfc4a

kamaljohnson requested a review from nabinhait August 26, 2021 05:29

nextchamp-saqib changed the title ~~Onboarding cleanup~~ feat: Accounts, Selling & Assets Onboarding cleanup Aug 26, 2021

nabinhait added 2 commits August 27, 2021 14:37

fix: removed duplicate section break

24b3e10

fix: Removed duplicate fields

bdaf335

nabinhait merged commit a285b5b into frappe:develop Aug 27, 2021

kamaljohnson deleted the onboarding_cleanup branch September 7, 2021 11:18

mergify bot mentioned this pull request Nov 22, 2021

feat: Accounts, Selling & Assets Onboarding cleanup (backport #27112) #28491

Merged

mergify bot mentioned this pull request Nov 22, 2021

feat: Accounts, Selling & Assets Onboarding cleanup (backport #27112) #28492

Closed

GangaManoj mentioned this pull request Dec 1, 2021

Asset Entry Error #26481

Closed

rohitwaghchaure mentioned this pull request Dec 5, 2021

chore: change log for v13.16.0 #28737

Merged

ankush mentioned this pull request Jun 20, 2022

Selling onboarding steps are disturbed in v14 #31409

Closed

deepeshgarg007 mentioned this pull request Jul 18, 2022

List of V14 features & enhancements #31620

Closed

github-actions bot locked as resolved and limited conversation to collaborators Feb 2, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Accounts, Selling & Assets Onboarding cleanup #27112

feat: Accounts, Selling & Assets Onboarding cleanup #27112

kamaljohnson commented Aug 24, 2021 •

edited by nabinhait

Loading

nabinhait commented Aug 26, 2021

kamaljohnson commented Aug 26, 2021

coveralls commented Aug 27, 2021

nextchamp-saqib commented Nov 22, 2021

mergify bot commented Nov 22, 2021

nextchamp-saqib commented Nov 22, 2021

mergify bot commented Nov 22, 2021

feat: Accounts, Selling & Assets Onboarding cleanup #27112

feat: Accounts, Selling & Assets Onboarding cleanup #27112

Conversation

kamaljohnson commented Aug 24, 2021 • edited by nabinhait Loading

Accounting

Assets

Selling

nabinhait commented Aug 26, 2021

kamaljohnson commented Aug 26, 2021

coveralls commented Aug 27, 2021

nextchamp-saqib commented Nov 22, 2021

mergify bot commented Nov 22, 2021

✅ Backports have been created

nextchamp-saqib commented Nov 22, 2021

mergify bot commented Nov 22, 2021

✅ Backports have been created

kamaljohnson commented Aug 24, 2021 •

edited by nabinhait

Loading