Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: show proper currency symbol in Taxes and Charges table #26935

Merged
merged 1 commit into from
Aug 13, 2021
Merged

fix: show proper currency symbol in Taxes and Charges table #26935

merged 1 commit into from
Aug 13, 2021

Conversation

frappe-pr-bot
Copy link
Collaborator

Backport 587d2db from #26827

@AfshanKhan @frappe-bot
fix: show proper currency symbol in taxes and charges table (frappe#2…
637a5e3 
…6827)

Co-authored-by: Saqib <nextchamp.saqib@gmail.com>
Co-authored-by: Deepesh Garg <42651287+deepeshgarg007@users.noreply.github.com>
(cherry picked from commit 587d2db)
@AfshanKhan AfshanKhan merged commit cb583a3 into frappe:version-13-hotfix Aug 13, 2021
This was referenced Sep 1, 2021
Merged
Merged
@ahmederp
Copy link

Feedback after committing the fix:
The changes did not affect the printed PDF standard format for Quotation Document. It shows fine in the print preview of the Quotation, but when converted to PDF it shows the Tax currency is the account or company currency not the document currency. It needs a second look to from print format point of view.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@deepeshgarg007 deepeshgarg007 Awaiting requested review from deepeshgarg007 deepeshgarg007 is a code owner

@nextchamp-saqib nextchamp-saqib Awaiting requested review from nextchamp-saqib

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@frappe-pr-bot @ahmederp @AfshanKhan