-
Notifications
You must be signed in to change notification settings - Fork 7.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fetch from more than one sales order in Maintenance Visit #26924
Conversation
This will also allow SOs from different customers to be pulled in a single Schedule / Visit, right? That will be kinda confusing since the document only has a single field for it. Maybe a reasonable restriction for this change could be that multiple SOs should be from the same customer? (Like how it's done in Pick List right now) |
You select a customer on the schedule and the search results in the dialogue are filtered by the customer selected already. Also, that is not part of this fix anyways. (Based on the customer the SOs are filtered already) |
This is not mandatory right now, so you can do "Get items from" and select multiple SOs with different customers. |
Ok maybe someone can pick it up from here then as this fix was intended to just fix the issue of not being able to select multiple items even if it is the same customer. Also being able to select other items which do not belong to the same customer is across the application as well, you can do it on delivery note as well and possibly other documents. |
…e#26924) * [fix] frappe#26336 * fix(ux): make customer field reqd for fetching SO Co-authored-by: Ankush Menat <ankush@iwebnotes.com> (cherry picked from commit db69d1d) # Conflicts: # erpnext/maintenance/doctype/maintenance_visit/maintenance_visit.js
…e#26924) * [fix] frappe#26336 * fix(ux): make customer field reqd for fetching SO Co-authored-by: Ankush Menat <ankush@iwebnotes.com> (cherry picked from commit db69d1d)
* fix: fetch from more than one sales order in Maintenance Visit (#26924) * [fix] #26336 * fix(ux): make customer field reqd for fetching SO # Conflicts: # erpnext/maintenance/doctype/maintenance_visit/maintenance_visit.js * fix: resolve conflicts Co-authored-by: Pawan Mehta <mehtapawan007@gmail.com> Co-authored-by: Ankush Menat <ankush@iwebnotes.com> (cherry picked from commit db69d1d)
…e#26924) * [fix] frappe#26336 * fix(ux): make customer field reqd for fetching SO Co-authored-by: Ankush Menat <ankush@iwebnotes.com>
Fixes #26336