Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fetch from more than one sales order in Maintenance Visit #26924

Merged
merged 2 commits into from
Aug 26, 2021

Conversation

PawanMeh
Copy link
Contributor

@PawanMeh PawanMeh commented Aug 12, 2021

Fixes #26336

@ankush ankush changed the title [fix] #26336 fix: fetch from more than one sales order in Maintenance Visit Aug 12, 2021
@ankush ankush added the squash Meant to tell reviewers that this PR should be squashed into a single commit while merging. label Aug 12, 2021
@ankush
Copy link
Member

ankush commented Aug 12, 2021

This will also allow SOs from different customers to be pulled in a single Schedule / Visit, right? That will be kinda confusing since the document only has a single field for it.

Maybe a reasonable restriction for this change could be that multiple SOs should be from the same customer? (Like how it's done in Pick List right now)

Screenshot 2021-08-12 at 7 29 05 PM

@PawanMeh
Copy link
Contributor Author

PawanMeh commented Aug 12, 2021

You select a customer on the schedule and the search results in the dialogue are filtered by the customer selected already. Also, that is not part of this fix anyways. (Based on the customer the SOs are filtered already)

@ankush
Copy link
Member

ankush commented Aug 12, 2021

You select a customer on the schedule

This is not mandatory right now, so you can do "Get items from" and select multiple SOs with different customers.

@PawanMeh
Copy link
Contributor Author

PawanMeh commented Aug 12, 2021

Ok maybe someone can pick it up from here then as this fix was intended to just fix the issue of not being able to select multiple items even if it is the same customer.

Also being able to select other items which do not belong to the same customer is across the application as well, you can do it on delivery note as well and possibly other documents.

delivery_note

@ankush ankush assigned ankush and unassigned noahjacob Aug 26, 2021
@ankush ankush merged commit db69d1d into frappe:develop Aug 26, 2021
frappe-pr-bot pushed a commit to frappe-pr-bot/erpnext that referenced this pull request Aug 26, 2021
…e#26924)

* [fix] frappe#26336

* fix(ux): make customer field reqd for fetching SO

Co-authored-by: Ankush Menat <ankush@iwebnotes.com>
(cherry picked from commit db69d1d)

# Conflicts:
#	erpnext/maintenance/doctype/maintenance_visit/maintenance_visit.js
frappe-pr-bot pushed a commit to frappe-pr-bot/erpnext that referenced this pull request Aug 26, 2021
…e#26924)

* [fix] frappe#26336

* fix(ux): make customer field reqd for fetching SO

Co-authored-by: Ankush Menat <ankush@iwebnotes.com>
(cherry picked from commit db69d1d)
ankush pushed a commit that referenced this pull request Aug 26, 2021
… (#27187)

* [fix] #26336

* fix(ux): make customer field reqd for fetching SO

Co-authored-by: Pawan Mehta <mehtapawan007@gmail.com>
Co-authored-by: Ankush Menat <ankush@iwebnotes.com>

(cherry picked from commit db69d1d)
ankush pushed a commit that referenced this pull request Aug 26, 2021
* fix: fetch from more than one sales order in Maintenance Visit (#26924)

* [fix] #26336

* fix(ux): make customer field reqd for fetching SO

# Conflicts:
#	erpnext/maintenance/doctype/maintenance_visit/maintenance_visit.js

* fix: resolve conflicts

Co-authored-by: Pawan Mehta <mehtapawan007@gmail.com>
Co-authored-by: Ankush Menat <ankush@iwebnotes.com>

(cherry picked from commit db69d1d)
asoral pushed a commit to asoral/erpnext that referenced this pull request Nov 12, 2021
…e#26924)

* [fix] frappe#26336

* fix(ux): make customer field reqd for fetching SO

Co-authored-by: Ankush Menat <ankush@iwebnotes.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport version-13-hotfix old-backport version-12-hotfix squash Meant to tell reviewers that this PR should be squashed into a single commit while merging.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get Items From in Maintenance Visit
3 participants