fix: Customers 'primary_address' not updated automatically (#26798) #26799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR is a fix for GitHub Issue 26798: frappe#26798 TLDR: When an Address is updated, and that Address is a Customer's Primary Address, update the Read Only field `customer.primary_address`
anupamvs
reviewed
Aug 6, 2021
erpnext/accounts/custom/address.py
Outdated
Comment on lines
33
to
35
| doc_customer = frappe.get_doc("Customer", customer_name[0]) | ||
| doc_customer.primary_address = address_display | ||
| doc_customer.save() |
There was a problem hiding this comment.
use frappe.db.set_value or frappe.db.update
There was a problem hiding this comment.
Why do you believe either of those would be an improvement?
There was a problem hiding this comment.
@PMojito Performance reasons.
get_doc fetches entire document, its child tables etc. Then save() goes through all the validations.
db.set_value bypasses all that and updates in a single SQL query.
There was a problem hiding this comment.
That's good feedback; change complete!
deepeshgarg007
approved these changes
Aug 9, 2021
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed within a week if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing. |
nabinhait
approved these changes
Aug 26, 2021
frappe-pr-bot
pushed a commit
to frappe-pr-bot/erpnext
that referenced
this pull request
Aug 26, 2021
) (frappe#26799) * Fix for Issue frappe#26798 This PR is a fix for GitHub Issue 26798: frappe#26798 TLDR: When an Address is updated, and that Address is a Customer's Primary Address, update the Read Only field `customer.primary_address` * Update address.py Co-authored-by: Deepesh Garg <42651287+deepeshgarg007@users.noreply.github.com> (cherry picked from commit 1a91977)
nabinhait
pushed a commit
that referenced
this pull request
Aug 26, 2021
…26799) (#27178) * Fix for Issue #26798 This PR is a fix for GitHub Issue 26798: #26798 TLDR: When an Address is updated, and that Address is a Customer's Primary Address, update the Read Only field `customer.primary_address` * Update address.py Co-authored-by: Deepesh Garg <42651287+deepeshgarg007@users.noreply.github.com> (cherry picked from commit 1a91977) Co-authored-by: Brian Pond <PMojito@users.noreply.github.com>
asoral
pushed a commit
to asoral/erpnext
that referenced
this pull request
Nov 12, 2021
) (frappe#26799) * Fix for Issue frappe#26798 This PR is a fix for GitHub Issue 26798: frappe#26798 TLDR: When an Address is updated, and that Address is a Customer's Primary Address, update the Read Only field `customer.primary_address` * Update address.py Co-authored-by: Deepesh Garg <42651287+deepeshgarg007@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #26798
TLDR: When an Address is updated, and that Address is a Customer's Primary Address, update the Read Only field
customer.primary_address