feat: Training Event Status Update and Validations #26698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed within a week if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing. |
|
Unrelated POS test case failing |
frappe-pr-bot
pushed a commit
to frappe-pr-bot/erpnext
that referenced
this pull request
Aug 16, 2021
* fix: training event employee status not updated on feedback submission * feat: update attendees status on training event status update * test: Training Event and Feedback * chore: remove unused import (cherry picked from commit bf75ea7)
ruchamahabal
added a commit
that referenced
this pull request
Aug 16, 2021
* fix: training event employee status not updated on feedback submission * feat: update attendees status on training event status update * test: Training Event and Feedback * chore: remove unused import (cherry picked from commit bf75ea7) Co-authored-by: Rucha Mahabal <ruchamahabal2@gmail.com>
This was referenced Sep 1, 2021
asoral
pushed a commit
to asoral/erpnext
that referenced
this pull request
Nov 12, 2021
* fix: training event employee status not updated on feedback submission * feat: update attendees status on training event status update * test: Training Event and Feedback * chore: remove unused import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After:
On submitting the Training Feedback, the employee status in the Training Event Attendees child table is updated to "Feedback Submitted". On canceling feedback, the status is reverted to "Completed".
training-feedback-status.mp4
Added validations for Training Feedback. Training Feedback cannot be added if:
a. Employee was Absent from the training.
b. Employee did not attend the training.
Training Event Status
a. If the status is marked as Completed, then for all the attendees, the status is set as Completed, provided the employee was Present and the status is not "Feedback Submitted"
b. If the status is marked as Scheduled, then for all the attendees, the status is marked as Open
employee-status.mp4
Added relevant tests for the same.
no-docsBasic Validations are added, which does not require documentation.