Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Fetch Payment Terms from linked Sales/Purchase Order #26397

Merged
merged 29 commits into from
Aug 11, 2021

Conversation

GangaManoj
Copy link
Contributor

@GangaManoj GangaManoj commented Jul 8, 2021

Issue:

  • Payment Terms are specified in Purchase Orders and Invoices, but not Receipts. Since most Purchase Invoices are created from Purchase Receipts, Payment Terms associated with linked Purchase Orders don't get fetched.
  • The Sales Cycle also has the same problem.

Fix:

  • Fetches Payment Terms from Purchase Order, whether the Invoice is created directly from the Order or it's created from a Purchase Receipt that was created from the Order.

Screenshot 2021-07-09 at 1 45 19 AM

  • Fetches Payment Terms from Sales Order, whether the Invoice is created directly from the Order or it's created from a Delivery Note that was created from the Order.

Screenshot 2021-07-17 at 10 57 57 PM

@coveralls
Copy link

coveralls commented Jul 8, 2021

Coverage Status

Coverage decreased (-0.05%) to 42.795% when pulling bf245e5 on GangaManoj:po-payment-terms into d1cb8d0 on frappe:develop.

@GangaManoj GangaManoj changed the title feat: Fetch Payment Terms from linked Purchase Order feat: Fetch Payment Terms from linked Sales/Purchase Order Jul 17, 2021
@deepeshgarg007 deepeshgarg007 merged commit f037bae into frappe:develop Aug 11, 2021
asoral pushed a commit to asoral/erpnext that referenced this pull request Nov 12, 2021
feat: Fetch Payment Terms from linked Sales/Purchase Order
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants