-
Notifications
You must be signed in to change notification settings - Fork 7.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Asset Repair #25798
Merged
nextchamp-saqib
merged 111 commits into
frappe:develop
from
GangaManoj:asset-repair-refactor
Jul 7, 2021
Merged
refactor: Asset Repair #25798
nextchamp-saqib
merged 111 commits into
frappe:develop
from
GangaManoj:asset-repair-refactor
Jul 7, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nextchamp-saqib
requested changes
Jun 24, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More changes. 😅
nextchamp-saqib
approved these changes
Jul 1, 2021
asoral
pushed a commit
to asoral/erpnext
that referenced
this pull request
Nov 12, 2021
refactor: Asset Repair
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Asset Repair
Changes
Decrease stock quantity for the items consumed during asset repair in the specified warehouse.
Add Total Repair Cost field. It contains the sum of Repair Cost and the total value of all stock items consumed during the repair.
Add Stock Consumed During Repair checkbox. If checked, it will display the Stock Consumption Details section and the Total Repair Cost field.
Add Purchase Invoice field so the user can record purchase of the repair service as well as the additional items necessary for repairing the asset.
Create GL entries to capitalise repair cost.
Add View General Ledger button.
Remove Assign To.
Add Asset Depreciation Details section with Increase In Asset Life field.
2. Asset
Changes
3. Company
Changes
- Rename _Fixed Asset Depreciation Settings_ section to _Fixed Asset Defaults_. - Add _Repair and Maintenance Account_.Docs: frappe/erpnext_documentation#357