Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: validate tax template for tax category #24402

Merged

Conversation

AfshanKhan
Copy link
Contributor

@AfshanKhan AfshanKhan commented Jan 18, 2021

Only one template should be available in "Purchase Taxes And Charges Templates" and "Sales Taxes And Charges Templates" for each Tax Category.

Steps for testing:

  1. Create a Tax Category
  2. Now make either a "Purchase Taxes And Charges Template" or a "Sales Taxes And Charges Template" and select the created Tax Category and save it.
  3. Now if you again try to create a "Purchase Taxes And Charges Template" if you had created that in step 2 or a "Sales Taxes And Charges Template" if you had created that in step 2 and select the same Tax Category then "A template with tax category {said tax category} already exists. Only one template is allowed with each tax category" is displayed to the user.

@AfshanKhan
Copy link
Contributor Author

Backport at #24403

@deepeshgarg007 deepeshgarg007 self-assigned this Jan 19, 2021
@nabinhait nabinhait merged commit e5529ad into frappe:develop Jan 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants