Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: removed all day event from shift assignment calendar #24397

Merged
merged 2 commits into from
Jan 28, 2021
Merged

fix: removed all day event from shift assignment calendar #24397

merged 2 commits into from
Jan 28, 2021

Conversation

Anurag810
Copy link
Contributor

@Anurag810 Anurag810 commented Jan 18, 2021 •
edited
Loading

The shift assigned to the employee was an all-day event but. the shift is a daily event with specific timing.
Before:
image

Now:
calendar_fix

@Anurag810 Anurag810 requested a review from AfshanKhan January 18, 2021 09:11
@nabinhait nabinhait merged commit 5756bf5 into frappe:develop Jan 28, 2021
@nabinhait nabinhait mentioned this pull request Apr 1, 2021
Merged
SaiFi0102 added a commit to ParaLogicTech/erpnext that referenced this pull request Mar 27, 2023
@SaiFi0102
fix: removed all day event from shift assignment calendar (frappe#24397)
fd63acf 
Co-authored-by: Afshan <33727827+AfshanKhan@users.noreply.github.com>
# Conflicts:
#	erpnext/hr/doctype/shift_assignment/shift_assignment.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nabinhait nabinhait nabinhait approved these changes

@AfshanKhan AfshanKhan AfshanKhan approved these changes

@rohitwaghchaure rohitwaghchaure Awaiting requested review from rohitwaghchaure

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Anurag810 @nabinhait @AfshanKhan