Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: gstr-1 double entry issue #24376

Merged
merged 3 commits into from
Jan 28, 2021
Merged

fix: gstr-1 double entry issue #24376

merged 3 commits into from
Jan 28, 2021

Conversation

pateljannat
Copy link
Contributor

Issue:

  1. Create a Sales Invoice with multiple rows in Taxes and Charges, make sure to have a row with rate set and one with rate as 0.

Screenshot 2021-01-12 at 1 53 30 PM

  1. GSTR-1 report shows double entries for such invoices.
  2. Because of this, the total value of the report was also getting affected.
  3. The report was considering tax rows with the rate 0 as well.

Screenshot 2021-01-12 at 1 50 01 PM

@pateljannat pateljannat requested a review from nabinhait January 14, 2021 14:35
@pateljannat pateljannat mentioned this pull request Jan 14, 2021
Merged
@nabinhait nabinhait merged commit 3914aca into frappe:develop Jan 28, 2021
@nabinhait nabinhait mentioned this pull request Apr 1, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nabinhait nabinhait nabinhait approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pateljannat @nabinhait