Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: to use Stock UoM in BOM Stock Report #24339

Merged
merged 5 commits into from
Jan 13, 2021

Conversation

Anuja-pawar
Copy link
Contributor

Issue:
On checking show exploded view, BOM Stock Report shows BOM Qty in Stock UoM instead of Item UoM, and not having a UoM column in the report creates a confusion as to why Qty suddenly changes. Also, considering Item UoM causes wrong results in Enough Parts to Build calculation, as it is checked against Stock Qty (Stock UoM).

Solution:
Added UoM column and modified UoM to Stock UoM irrespective of the status of show exploded view checkbox.

@Anuja-pawar Anuja-pawar removed the request for review from marination January 11, 2021 09:12
@Anuja-pawar Anuja-pawar changed the title fix: modified item UoM to stock UoM in BOM Stock Report fix: to use Stock UoM in BOM Stock Report Jan 11, 2021
@marination marination self-assigned this Jan 11, 2021
@nabinhait nabinhait merged commit 0b04e23 into frappe:develop Jan 13, 2021
@nabinhait
Copy link
Member

@Anuja-pawar Should be fixed in version-12 as well?

@Anuja-pawar
Copy link
Contributor Author

@Anuja-pawar Should be fixed in version-12 as well?

Yes, will backport this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants