Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not manufacture same serial no multiple times #24164

Merged
merged 3 commits into from
Dec 24, 2020
Merged

fix: do not manufacture same serial no multiple times #24164

merged 3 commits into from
Dec 24, 2020

Conversation

rohitwaghchaure
Copy link
Collaborator

@rohitwaghchaure rohitwaghchaure commented Dec 16, 2020 •
edited
Loading

backport #24163

Issue

  1. Create item with has serial no and make BOM against it
  2. Create work order against it and put serial no as "SN-00001"
  3. Make delivery note against the same item and put serial no as "SN-00001"
  4. Create new work order against the same item and while completing manufacturing entry put same serial no as "SN-00001"
  5. Here system allowing to manufacture same serial number multiple times, ideal it should not allowed.

After Fix

image

@rohitwaghchaure rohitwaghchaure merged commit 630258f into frappe:develop Dec 24, 2020
@nabinhait nabinhait mentioned this pull request Apr 1, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marination marination Awaiting requested review from marination

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rohitwaghchaure @Anurag810