fix: fix for not having fiscal year while creating new company #24130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anurag810
previously approved these changes
Dec 16, 2020
nabinhait
requested changes
Jan 13, 2021
…any_fiscal_year_issue
…pawar/erpnext into company_fiscal_year_issue
nabinhait
approved these changes
Jan 14, 2021
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: If you have multiple fiscal years with multiple companies, when you create a new company it may throw this error even if you have a fiscal year for a current date since it is applicable to a particular company.
The fiscal year is required to get TDS rates while setting a chart of accounts for a new company. Now you can not create another fiscal year with dates overlapping with the existing fiscal year, or to create a fiscal year specific to this new company, you need to create a company first.
Solution: This fix handles this error and lets the user create a new company irrespective of that. The user will have to add TDS rates later in this case.