Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: job card error handling for operations field #23991

Merged
merged 1 commit into from
Nov 24, 2020
Merged

fix: job card error handling for operations field #23991

merged 1 commit into from
Nov 24, 2020

Conversation

pateljannat
Copy link
Contributor

Issue:

  1. In a Job Card, the Operation field has a filter based on the Work Order selected.
  2. So when the user clicks on the Operation field without selecting a Work Order, an error appears.

Screenshot 2020-11-24 at 3 44 19 PM

Fix:

  1. Error handling for the scenario where the Operation field is clicked before selecting Work Order.
  2. Message is displayed to the user asking them to select a Work Order in this scenario.

Screenshot 2020-11-24 at 3 40 58 PM

@rohitwaghchaure rohitwaghchaure merged commit 5ab2e6c into frappe:develop Nov 24, 2020
@rohitwaghchaure
Copy link
Collaborator

@pateljannat do backport on version-12-hotfix

@nabinhait nabinhait mentioned this pull request Apr 1, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohitwaghchaure rohitwaghchaure rohitwaghchaure approved these changes

@marination marination Awaiting requested review from marination

@ruchamahabal ruchamahabal Awaiting requested review from ruchamahabal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pateljannat @rohitwaghchaure