Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: SO to PO Mapping Issue #23820

Merged
merged 5 commits into from
Nov 5, 2020
Merged

fix: SO to PO Mapping Issue #23820

merged 5 commits into from
Nov 5, 2020

Conversation

marination
Copy link
Collaborator

@marination marination commented Nov 4, 2020 •
edited
Loading

  • Mapping would fail sometimes, due to the AJAX request URL being too long (request type was 'GET')
  • The whole row object of the items table was mapped and sent via the request, a lot of unncessary info. The request was bulky, and due to bulky args being appended to the URL it failed

Fix:

  • removed request type, not a crazy long URL
    Screenshot 2020-11-04 at 8 27 49 PM

  • Only send relevant fields from child table row to server side

  • Created separate function to set dialog table data

  • Added freeze message
    so-to-po-fix

ToDo:

  • Make rows non editable (some sort of grid bug WIP)

@marination
fix: SO to PO Mapping Issue
23b7591 
- removed type: GET , which made the URL longer
- Added only relevant fields from Items table to Dialog table to reduce args load
- Made separate method to set table data in dialog
- Added freeze message
@marination
fix: Make sure row object has doctype so that read only property is a…
2b8aa91 
…pplied to rows
@marination marination mentioned this pull request Nov 4, 2020
Merged
@marination marination merged commit 08f6c9d into frappe:develop Nov 5, 2020
@marination marination mentioned this pull request Nov 12, 2020
Merged
@nabinhait nabinhait mentioned this pull request Apr 1, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@marination