Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix for LMS Sign Up link #23743

Merged
merged 3 commits into from
Oct 29, 2020
Merged

Conversation

mujeerhashmi
Copy link
Contributor

Fixes #23742

Signed-off-by: Syed Mujeer Hashmi mujeerhashmi@4csolutions.in

Please provide enough information so that others can review your pull request:

Explain the details for making this change. What existing problem does the pull request solve?

Screenshots/GIFs

@mujeerhashmi mujeerhashmi changed the title Fix: Fix for LMS Sign Up link fix: Fix for LMS Sign Up link Oct 28, 2020
Signed-off-by: Syed Mujeer Hashmi <mujeerhashmi@4csolutions.in>
@ruchamahabal
Copy link
Member

@mujeerhashmi Can you add GIFs or Screenshots for before and after scenarios?

@mujeerhashmi
Copy link
Contributor Author

@ruchamahabal

Before:

LMS-Before

After:

LMS-After

@ruchamahabal ruchamahabal merged commit c17cdd7 into frappe:develop Oct 29, 2020
@ruchamahabal
Copy link
Member

@Mergifyio backport version-12-hotfix

@mergify
Copy link
Contributor

mergify bot commented Oct 29, 2020

Command backport version-12-hotfix: failure

No backport have been created

  • Backport to branch version-12-hotfix failed
    backport fail: repository is too big and no subscription is active

@mujeerhashmi mujeerhashmi deleted the lms-fix branch January 7, 2022 02:52
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LMS Sign Up link is broken.
3 participants