Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Payment Terms not fetched in Purchase Invoice from Purchase Receipt #23735

Merged

Conversation

marination
Copy link
Collaborator

@marination marination commented Oct 27, 2020

Issue:

  • Create PO and PR against it
  • Now create a Purchase Invoice against this Purchase Receipt, the Payment Terms Template is fetched but the Terms are not fetched from the Template
  • This occurs due to the incorrect order of events.
  • From PR to PI, PI's onload is called via the doc mapper, at this time it gets no Payment Terms Template. Thus, it adds a row for Payment terms with invoice portion 100%
  • After this, Template is fetched and set from client side, but since table is populated, it does nothing
    ptt_issue

Fix:

  • Set the Template while mapping the doc so that during onload it will fetch the correct Terms
  • Renamed get_pyt_term_template => get_payment_terms_template
    ptt

@marination
Copy link
Collaborator Author

Screenshot 2020-10-27 at 2 50 21 PM

@marination
Copy link
Collaborator Author

@Mergifyio backport version-12-hotfix

@mergify
Copy link
Contributor

mergify bot commented Oct 27, 2020

Command backport version-12-hotfix: pending

Waiting for the pull request to get merged

@marination marination merged commit 2d4a349 into frappe:develop Nov 9, 2020
@mergify
Copy link
Contributor

mergify bot commented Nov 9, 2020

Command backport version-12-hotfix: failure

No backport have been created

  • Backport to branch version-12-hotfix failed
    backport fail: repository is too big and no subscription is active

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants