Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Loan repayment type option remove #23582

Merged
merged 34 commits into from
Nov 11, 2020
Merged

fix: Loan repayment type option remove #23582

merged 34 commits into from
Nov 11, 2020

Conversation

deepeshgarg007
Copy link
Member

@deepeshgarg007 deepeshgarg007 commented Oct 11, 2020 •
edited
Loading

  • Removed Payment Type option from Loan Repayment. Now repayments can be made against a loan without specifying any payment type

  • Added Accrual Type in Loan Interest Accrual. There can be three types of loan interest accrual

  1. Monthly accrual which happens periodically (Regular)
  2. In case of excess interest paid against a loan (Repayment)
  3. Partial Disbursements or Loan Topup (Disbursement)

Screenshot 2020-10-11 at 12 58 43 PM

  • Added method to request loan closure
  • Other minor enhancement like adding penalty amount in Loan Interest Accruals

Added new doctype "Loan Write Off" to write off pending principal amount

image

  • Added write off limit in loan type doctype, amount in this field will be automatically ignored on loan closure request

Docs: frappe/erpnext_documentation#180

@deepeshgarg007 deepeshgarg007 force-pushed the loan_repayment_type_remove branch from 8da52b3 to 54c8987 Compare October 13, 2020 12:42
@deepeshgarg007 deepeshgarg007 force-pushed the loan_repayment_type_remove branch from 99c8826 to ca6cb64 Compare October 22, 2020 16:23
@deepeshgarg007 deepeshgarg007 merged commit 5e0f4e2 into frappe:develop Nov 11, 2020
@nabinhait nabinhait mentioned this pull request Apr 1, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohitwaghchaure rohitwaghchaure Awaiting requested review from rohitwaghchaure

Assignees
No one assigned
Labels
dont-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@deepeshgarg007